Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update openshift/api for types and gates #316

Merged
merged 1 commit into from Jun 2, 2023
Merged

update openshift/api for types and gates #316

merged 1 commit into from Jun 2, 2023

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 2, 2023

No description provided.

@openshift-ci openshift-ci bot requested review from JoelSpeed and tkashem June 2, 2023 15:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon
Copy link
Contributor

/hold
openshift/api#1480

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@patrickdillon
Copy link
Contributor

/hold openshift/api#1480

Feel free to drop the hold, just wanted to note that I caught this and perhaps it would be easier to fix then revendor

@deads2k
Copy link
Contributor Author

deads2k commented Jun 2, 2023

/hold cancel

open another with the new update.

@deads2k deads2k added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 2, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@deads2k
Copy link
Contributor Author

deads2k commented Jun 2, 2023

adds featuregates to allow features to isolate.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5a2df6c into openshift:master Jun 2, 2023
8 checks passed
@patrickdillon
Copy link
Contributor

/hold cancel

open another with the new update.

Reopened #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deads2k @JoelSpeed @patrickdillon @openshift-merge-robot