Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump to enable ValidatingAdmissionPolicy in tech preview." #346

Merged
merged 1 commit into from Aug 22, 2023

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 22, 2023

This reverts commit a6e6a81.

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@deads2k
Copy link
Contributor Author

deads2k commented Aug 22, 2023

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Aug 22, 2023

going for it as our best shot at avoiding uninstallable payload.

the failure mode, we had the original merge order as

  1. update cluster-config-operator to disable validatingadmissionpolicy
  2. update kube-apiserver-operator to handle enabling validatingadmissionpolicy for enabling APIs
  3. update cluster-config-operator to enable validatingadmissionpolicy. This SHOULD have failed on techpreview serial, but we don't test techpreview serial (yet)
  4. update kube-apiserver-operator to enable another API that was forgotten

@deads2k deads2k merged commit 084892b into openshift:master Aug 22, 2023
3 of 8 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

@deads2k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify dfd0cbd link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Aug 22, 2023

�[36mINFO�[0m[2023-08-22T14:31:34Z] Running step e2e-aws-ovn-techpreview-ipi-install-install. 
�[36mINFO�[0m[2023-08-22T15:01:59Z] Step e2e-aws-ovn-techpreview-ipi-install-install succeeded after 30m25s. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant