Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-26542: remove duplicate manifests in image #395

Merged
merged 1 commit into from Apr 1, 2024
Merged

[release-4.15] OCPBUGS-26542: remove duplicate manifests in image #395

merged 1 commit into from Apr 1, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #392

/assign deads2k

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 9, 2024
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-26541 has been cloned as Jira Issue OCPBUGS-26542. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-26542: remove duplicate manifests in image

In response to this:

This is an automated cherry-pick of #392

/assign deads2k

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deads2k
Copy link
Contributor

deads2k commented Jan 9, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-26541: remove duplicate manifests in image [release-4.15] OCPBUGS-26542: remove duplicate manifests in image Jan 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 9, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-26542, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-26541 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-26541 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #392

/assign deads2k

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 9, 2024
@JoelSpeed
Copy link
Contributor

/hold

HyperShift was broken by merging this into master, they are reverting master and will unrevert once they've come up with a fix

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2024
@sjenning
Copy link
Contributor

/hold
This busted hypershift e2e in 4.16

@deads2k
Copy link
Contributor

deads2k commented Jan 22, 2024

/test all

@deads2k
Copy link
Contributor

deads2k commented Jan 22, 2024

Got the ok to merge now: https://redhat-internal.slack.com/archives/C01C8502FMM/p1705935648156829

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@gangwgr
Copy link

gangwgr commented Mar 25, 2024

/retest-required

@gangwgr
Copy link

gangwgr commented Apr 1, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 1, 2024
@deads2k deads2k added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ceadbc1 into openshift:release-4.15 Apr 1, 2024
10 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-26542: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26542 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #392

/assign deads2k

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-operator-container-v4.15.0-202404011209.p0.gceadbc1.assembly.stream.el9 for distgit ose-cluster-config-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-04-02-015344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gangwgr gangwgr Awaiting requested review from gangwgr

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@deads2k deads2k

@xingxingxia xingxingxia

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@openshift-cherrypick-robot @openshift-ci-robot @deads2k @JoelSpeed @sjenning @gangwgr @openshift-bot @openshift-merge-robot @xingxingxia @wangke19