Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-28621: Add required PSa labels #401

Merged
merged 1 commit into from Jan 31, 2024

Conversation

liouk
Copy link
Member

@liouk liouk commented Jan 29, 2024

This PR sets the required PSa labels for the openshift-config namespace.

Namespaces that don't define PSa labels currently get restricted by default; this results in violations from workloads that run in the openshift-config namespace, as this is a runlevel 0 namespace and likely these payloads need privileged policy.

See https://issues.redhat.com/browse/AUTH-262 for more information.

@stlaz
Copy link
Member

stlaz commented Jan 29, 2024

/retest-required

@deads2k
Copy link
Contributor

deads2k commented Jan 29, 2024

/lgtm
/approve

@liouk
Copy link
Member Author

liouk commented Jan 29, 2024

/retest-required

1 similar comment
@liouk
Copy link
Member Author

liouk commented Jan 30, 2024

/retest-required

@liouk liouk changed the title Add required PSa labels AUTH-476: Add required PSa labels Jan 30, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2024

@liouk: This pull request references AUTH-476 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This PR sets the required PSa labels for the openshift-config namespace.

Namespaces that don't define PSa labels currently get restricted by default; this results in violations from workloads that run in the openshift-config namespace, as this is a runlevel 0 namespace and likely these payloads need privileged policy.

See https://issues.redhat.com/browse/AUTH-262 for more information.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liouk
Copy link
Member Author

liouk commented Jan 30, 2024

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2024

@liouk: This pull request references AUTH-476 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liouk liouk changed the title AUTH-476: Add required PSa labels OCPBUGS-28621: Add required PSa labels Jan 30, 2024
@openshift-ci-robot
Copy link

@liouk: This pull request references Jira Issue OCPBUGS-28621, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR sets the required PSa labels for the openshift-config namespace.

Namespaces that don't define PSa labels currently get restricted by default; this results in violations from workloads that run in the openshift-config namespace, as this is a runlevel 0 namespace and likely these payloads need privileged policy.

See https://issues.redhat.com/browse/AUTH-262 for more information.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 30, 2024
@liouk
Copy link
Member Author

liouk commented Jan 30, 2024

/jira refresh

@openshift-ci-robot
Copy link

@liouk: This pull request references Jira Issue OCPBUGS-28621, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liouk
Copy link
Member Author

liouk commented Jan 30, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 30, 2024
@openshift-ci-robot
Copy link

@liouk: This pull request references Jira Issue OCPBUGS-28621, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 30, 2024
@liouk
Copy link
Member Author

liouk commented Jan 30, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

@liouk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Jan 30, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 17743de into openshift:master Jan 31, 2024
10 checks passed
@openshift-ci-robot
Copy link

@liouk: Jira Issue OCPBUGS-28621: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28621 has not been moved to the MODIFIED state.

In response to this:

This PR sets the required PSa labels for the openshift-config namespace.

Namespaces that don't define PSa labels currently get restricted by default; this results in violations from workloads that run in the openshift-config namespace, as this is a runlevel 0 namespace and likely these payloads need privileged policy.

See https://issues.redhat.com/browse/AUTH-262 for more information.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-operator-container-v4.16.0-202401311812.p0.g17743de.assembly.stream for distgit ose-cluster-config-operator.
All builds following this will include this PR.

@liouk
Copy link
Member Author

liouk commented Feb 1, 2024

/jira refresh

@openshift-ci-robot
Copy link

@liouk: Jira Issue OCPBUGS-28621: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28621 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-02-002725

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-07-073830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants