Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Bump API docs for config.openshift.io #86

Closed
wants to merge 2 commits into from

Conversation

adambkaplan
Copy link
Contributor

No description provided.

Pull in API doc updates for config.openshift.io objects.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adambkaplan
To complete the pull request process, please assign sttts
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 22, 2019
@openshift-ci-robot
Copy link

@adambkaplan: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/images 33554a4 link /test images
ci/prow/e2e-aws-upgrade 33554a4 link /test e2e-aws-upgrade
ci/prow/verify 33554a4 link /test verify
ci/prow/e2e-aws 33554a4 link /test e2e-aws
ci/prow/unit 33554a4 link /test unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor Author

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavdahiya please see issue with the bump via glide.

subpackages:
- cli/flag
- logs
- name: k8s.io/klog
version: 8e90cee79f823779174776412c13478955131846
version: cd60aa438f9c750641d5feacd2999e58df8af28f
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow this version of klog is not compatible with the vendored k8s.io/client-go. How did this happen?

@adambkaplan
Copy link
Contributor Author

/cc @sttts

@ironcladlou
Copy link

@adambkaplan
Copy link
Contributor Author

/close

Replaced by #87

@openshift-ci-robot
Copy link

@adambkaplan: Closed this PR.

In response to this:

/close

Replaced by #87

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants