Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-1750: e2e presubmit test: activating ControlPlaneMachineSet adds owner references #145

Merged
merged 1 commit into from Nov 28, 2022
Merged

OCPCLOUD-1750: e2e presubmit test: activating ControlPlaneMachineSet adds owner references #145

merged 1 commit into from Nov 28, 2022

Conversation

damdo
Copy link
Member

@damdo damdo commented Nov 25, 2022 •
edited

This adds a check to the E2E suite that confirms that, when the machines are up to date and the control plane machine set is activated, the correct owner references are added.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2022
@damdo damdo changed the title OCPCLOUD-1746: e2e presubmit test: activating ControlPlaneMachineSet adds owner references OCPCLOUD-1750: e2e presubmit test: activating ControlPlaneMachineSet adds owner references Nov 25, 2022
@damdo
Copy link
Member Author

damdo commented Nov 25, 2022

/jira refresh

@openshift-ci-robot
Copy link

@damdo: No Jira bug is referenced in the title of this pull request.
To reference a bug, add 'OCPBUGS-XXX:' to the title of this pull request and request another bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo
Copy link
Member Author

damdo commented Nov 25, 2022

/hold

until #140 merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2022
@damdo damdo force-pushed the e2e-activating-cpms-adds-owner-refs branch from 4b9068c to 2ed6c90 Compare November 25, 2022 16:59
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2022
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2022
@damdo damdo force-pushed the e2e-activating-cpms-adds-owner-refs branch from 2ed6c90 to 84b8066 Compare November 25, 2022 17:02
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2022
@damdo damdo force-pushed the e2e-activating-cpms-adds-owner-refs branch from 84b8066 to d44fe22 Compare November 25, 2022 21:04
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2022
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 25, 2022
@damdo
Copy link
Member Author

damdo commented Nov 25, 2022

/unhold
#140 merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2022

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0984d71 into openshift:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@damdo @openshift-ci-robot @JoelSpeed @openshift-merge-robot