OCPBUGS-20070: fix: e2e: add gcp custom type to test framework #244
Conversation
openshift-ci-robot
added
jira/severity-low
|
@damdo: This pull request references Jira Issue OCPBUGS-20070, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/M
|
/test periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.15-periodics-e2e-gcp |
|
@RadekManak: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@RadekManak the only periodic pre available is for AWS. |
|
But it looks like in the presubmits we do run the increase instance size step. So let's see if that passes, and if we get those e2-custom machines for that.Otherwise we might need to try and test it in a different way. |
|
/test e2e-gcp-operator |
|
/lgtm |
|
/assign @JoelSpeed |
test/e2e/framework/framework.go
Outdated
| return "", fmt.Errorf("%w: %s", errInstanceTypeNotSupported, current) | ||
| } | ||
|
|
||
| return fmt.Sprintf("%s-%s-%d-%d", family, subfamily, multiplier+1, multiplier2+256), nil |
There was a problem hiding this comment.
Where did the +1 and +256 come from?
There was a problem hiding this comment.
I believe it comes from this doc for custom GCP instances: https://cloud.google.com/compute/docs/instances/creating-instance-with-custom-machine-type
There was a problem hiding this comment.
Reading that, it suggests that memory is relatively free in what we can spec, so +256 is ok, but it suggests that CPUs can be "1 to 96 or any even value in between".
I don't think we are accounting for the even part of the above statement
There was a problem hiding this comment.
According to: https://cloud.google.com/compute/docs/general-purpose-machines#custom_machine_types
E2 custom machine types support predefined platforms with Intel or AMD EPYC processors. You can create E2 custom machine types with vCPUs in multiples of 2, up to 32 vCPUs. The minimum acceptable number of vCPUs for a VM is 2.
There is also a constraint for memory - cpu cores ratio (shown in this example of invalid instance):
32 vCPUs, 1 GB of total memory. Invalid because the ratio of vCPUs to memory is incorrect. The acceptable ratio is 0.5 GB of memory to 1 vCPU.
There was a problem hiding this comment.
Ahh good catch @JoelSpeed. I looked at the limitations section but couldn't find anything regarding CPU.
Thanks for flagging, will update this.
There was a problem hiding this comment.
I've updated it by taking into account all the limitations described in the doc that @odvarkadaniel shared.
openshift-ci
bot
added
size/L
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@damdo: This pull request references Jira Issue OCPBUGS-20070, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damdo: This pull request references Jira Issue OCPBUGS-20070, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damdo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Can you take a look again when you got some time @JoelSpeed ? Tx |
|
/approve |
|
@damdo: This pull request references Jira Issue OCPBUGS-20070, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@damdo: Jira Issue OCPBUGS-20070: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-20070 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/payload-job periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.15-periodics-e2e-gcp |
|
@damdo: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/79ca7ea0-6781-11ee-8888-5dc01135b3cb-0 |
Fixes a test framework failure by adding the GCP instance custom type support to it.