Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.13] OCPBUGS-20482: fix: e2e: add gcp custom type to test framework #249

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #247

/assign damdo

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-20408 has been cloned as Jira Issue OCPBUGS-20482. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-20482: fix: e2e: add gcp custom type to test framework

In response to this:

This is an automated cherry-pick of #247

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-20408: fix: e2e: add gcp custom type to test framework [release-4.13] OCPBUGS-20482: fix: e2e: add gcp custom type to test framework Oct 12, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 12, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-20482, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20408 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #247

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 12, 2023
@damdo
Copy link
Member

damdo commented Oct 12, 2023

/payload-job periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.14-periodics-e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@damdo: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.14-periodics-e2e-gcp

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5fe94270-68f6-11ee-9474-eb05fe6213ee-0

@JoelSpeed
Copy link
Contributor

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 12, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@damdo
Copy link
Member

damdo commented Oct 12, 2023

/payload-job periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.14-periodics-e2e-gcp

@damdo
Copy link
Member

damdo commented Oct 12, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@damdo: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.14-periodics-e2e-gcp

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e8c127b0-6910-11ee-9b55-ea40f1a11141-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 65a5865 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@damdo
Copy link
Member

damdo commented Oct 12, 2023

/payload-job periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.13-periodics-e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@damdo: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.13-periodics-e2e-gcp

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bc4de9f0-6935-11ee-95ea-82a3c722b7b7-0

@damdo
Copy link
Member

damdo commented Oct 12, 2023

/retest

@damdo
Copy link
Member

damdo commented Oct 13, 2023

The manually triggered periodic passed!

@damdo
Copy link
Member

damdo commented Oct 13, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 13, 2023
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-20482, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20408 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-20408 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @miyadav

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 13, 2023
@openshift-ci openshift-ci bot requested a review from miyadav October 13, 2023 08:25
@JoelSpeed JoelSpeed added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 13, 2023
@JoelSpeed
Copy link
Contributor

Since this only affects our E2E tests and we have demonstrated that the E2Es are passing reliably, manually adding cherry pick approved label

@openshift-ci openshift-ci bot merged commit 383a69c into openshift:release-4.13 Oct 13, 2023
14 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-20482: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20482 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #247

/assign damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2023-10-13-174847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants