Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1410: Fix vSphere machineprovider InjectFailureDomain to handle empty network device list. #281

Merged
merged 1 commit into from Feb 21, 2024
Merged

SPLAT-1410: Fix vSphere machineprovider InjectFailureDomain to handle empty network device list. #281

merged 1 commit into from Feb 21, 2024

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Feb 20, 2024 •
edited by openshift-ci bot

SPLAT-1410

Changes

  • Fixed vsphere machineprovider to handle empty network device list when injecting failure domain

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2024 •
edited by openshift-ci bot

@vr4manta: This pull request references SPLAT-1410 which is a valid jira issue.

In response to this:

SPLAT-1410

Changes

  • Fixed vsphere machineprovider to handle empty network device list when injecting failure domain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2024 •
edited by openshift-ci bot

@vr4manta: This pull request references SPLAT-1410 which is a valid jira issue.

In response to this:

SPLAT-1410

Changes

  • Fixed vsphere machineprovider to handle empty network device list when injecting failure domain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2024
@openshift-ci openshift-ci bot requested review from damdo and nrb February 20, 2024 23:10
@vr4manta
Copy link
Contributor Author

/test unit

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-operator 44f7b60 link false /test e2e-openstack-operator
ci/prow/e2e-azure-operator 44f7b60 link false /test e2e-azure-operator
ci/prow/e2e-vsphere-multi-zone-operator 44f7b60 link false /test e2e-vsphere-multi-zone-operator
ci/prow/e2e-openstack-operator-zone 44f7b60 link false /test e2e-openstack-operator-zone
ci/prow/e2e-azure-ovn-etcd-scaling 44f7b60 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-nutanix-ovn 44f7b60 link false /test e2e-nutanix-ovn
ci/prow/e2e-vsphere-ovn-etcd-scaling 44f7b60 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-vsphere-operator 44f7b60 link false /test e2e-vsphere-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

damdo
damdo reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@vr4manta
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 01b7f32 into openshift:main Feb 21, 2024
16 of 24 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-control-plane-machine-set-operator-container-v4.16.0-202402211939.p0.g01b7f32.assembly.stream.el9 for distgit ose-cluster-control-plane-machine-set-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@nrb nrb Awaiting requested review from nrb

Assignees

@damdo damdo

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vr4manta @openshift-ci-robot @openshift-bot @damdo