[release-4.15] OCPBUGS-34971: Add unreadyNodeGracePeriod for allowing brief node hiccups

[openshift-cherrypick-robot]

This is an automated cherry-pick of #294

/assign damdo

/cherrypick release-4.14 release-4.13 release 4.12

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-20061 has been cloned as Jira Issue OCPBUGS-34971. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-34971: Add unreadyNodeGracePeriod for allowing brief node hiccups

In response to this:

This is an automated cherry-pick of #294

/assign damdo

/cherrypick release-4.14 release-4.13 release 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-34971, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected dependent Jira Issue OCPBUGS-20061 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
• expected dependent Jira Issue OCPBUGS-20061 to target a version in 4.16.0, but it targets "4.17.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #294

/assign damdo

/cherrypick release-4.14 release-4.13 release 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/hold
Until the change in 4.17 has been rehearsed for a bit

[damdo]

/retest

[damdo]

/retest
/jira refresh

[openshift-ci-robot]

@damdo: This pull request references Jira Issue OCPBUGS-34971, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected dependent Jira Issue OCPBUGS-20061 to target a version in 4.16.0, but it targets "4.17.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/retest
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/cherry-pick release-4.14 release-4.13 release-4.12

[openshift-cherrypick-robot]

@damdo: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14 release-4.13 release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[damdo]

/jira refresh
/label backport-risk-assessed

[openshift-ci-robot]

@damdo: This pull request references Jira Issue OCPBUGS-34971, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected dependent Jira Issue OCPBUGS-20061 to target a version in 4.16.0, but it targets "4.17.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/jira refresh

[openshift-ci-robot]

@damdo: This pull request references Jira Issue OCPBUGS-34971, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/jira refresh

[openshift-ci-robot]

@damdo: This pull request references Jira Issue OCPBUGS-34971, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.z) matches configured target version for branch (4.15.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-34970 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-34970 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
• bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

/cc @miyadav

[damdo]

/retest

[damdo]

/lgtm

/assign @JoelSpeed

[JoelSpeed]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sunzhaohua2]

/label cherry-pick-approved

[damdo]

/unhold

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c9afc05 and 2 for PR HEAD 9f4fddd in total

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-34971: All pull requests linked via external trackers have merged:

• openshift/cluster-control-plane-machine-set-operator#299

Jira Issue OCPBUGS-34971 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #294

/assign damdo

/cherrypick release-4.14 release-4.13 release 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@openshift-cherrypick-robot: #299 failed to apply on top of branch "release-4.14":

Applying: add unreadyNodeGracePeriod for allowing brief node hiccups
Using index info to reconstruct a base tree...
M	pkg/machineproviders/providers/openshift/machine/v1beta1/provider.go
M	pkg/machineproviders/providers/openshift/machine/v1beta1/provider_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/machineproviders/providers/openshift/machine/v1beta1/provider_test.go
Auto-merging pkg/machineproviders/providers/openshift/machine/v1beta1/provider.go
CONFLICT (content): Merge conflict in pkg/machineproviders/providers/openshift/machine/v1beta1/provider.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add unreadyNodeGracePeriod for allowing brief node hiccups
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

This is an automated cherry-pick of #294

/assign damdo

/cherrypick release-4.14 release-4.13 release 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-control-plane-machine-set-operator-container-v4.15.0-202406191706.p0.g603c1bc.assembly.stream.el9 for distgit ose-cluster-control-plane-machine-set-operator.
All builds following this will include this PR.