OCPBUGS-35416: Wait for ControlPlaneMachineSet to be created when waiting for it to be updated #305
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@JoelSpeed: This pull request references Jira Issue OCPBUGS-35416, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
openshift-ci
bot
added
the
size/XS
| cpms := &machinev1.ControlPlaneMachineSet{} | ||
| cpms := testFramework.NewEmptyControlPlaneMachineSet() | ||
| Eventually(komega.Get(cpms)).Should(Succeed(), "control plane machine set should exist") | ||
|
|
||
| Expect(k8sClient.Get(testFramework.GetContext(), testFramework.ControlPlaneMachineSetKey(), cpms)).To(Succeed(), "control plane machine set should exist") |
There was a problem hiding this comment.
Can/Should we drop this if we have the eventually above?
There was a problem hiding this comment.
Oops... I had thought I had done so 😅
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@JoelSpeed: Jira Issue OCPBUGS-35416: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-35416 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-control-plane-machine-set-operator-container-v4.17.0-202406140211.p0.g69ab2b7.assembly.stream.el9 for distgit ose-cluster-control-plane-machine-set-operator. |
|
@damdo: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.16 |
|
@damdo: new pull request created: #307 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Seeing this in presubmits sometimes. One of the tests using this helper expects the CPMS generator to regenerate the CPMS right at the end of the test, but we then immediately call
EnsureControlPlaneMachineSetUpdatedwhich expects the CPMS to exist.In the right conditions, this second helper can catch the generator mid way between delete and create as it regenerates, and that causes the test to fail with a not found error.
This should help to prevent that.