[4.15] OCPBUGS-31599: create suitable role and roleBinding for csi-snapshot-webhook #203
Conversation
|
@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobsonj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira cherry-pick OCPBUGS-31497 |
|
@dobsonj: Jira Issue OCPBUGS-31497 has been cloned as Jira Issue OCPBUGS-31599. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@dobsonj: This pull request references Jira Issue OCPBUGS-31599, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/label backport-risk-assessed |
|
@dobsonj: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
backport-risk-assessed
dobsonj
changed the title
|
Hi @dobsonj, I checked the CI must-gather seems the webhook logs still have some omc logs csi-snapshot-webhook-75d8ffb974-j4427
2024-04-01T22:01:05.358426627Z I0401 22:01:05.358322 1 certwatcher.go:129] Updated current TLS certificate
2024-04-01T22:01:05.374647968Z W0401 22:01:05.374603 1 reflector.go:535] github.com/kubernetes-csi/external-snapshotter/client/v6/informers/externalversions/factory.go:133: failed to list *v1alpha1.VolumeGroupSnapshotClass: volumegroupsnapshotclasses.groupsnapshot.storage.k8s.io is forbidden: User "system:serviceaccount:openshift-cluster-storage-operator:csi-snapshot-webhook" cannot list resource "volumegroupsnapshotclasses" in API group "groupsnapshot.storage.k8s.io" at the cluster scope
2024-04-01T22:01:05.374647968Z E0401 22:01:05.374637 1 reflector.go:147] github.com/kubernetes-csi/external-snapshotter/client/v6/informers/externalversions/factory.go:133: Failed to watch *v1alpha1.VolumeGroupSnapshotClass: failed to list *v1alpha1.VolumeGroupSnapshotClass: volumegroupsnapshotclasses.groupsnapshot.storage.k8s.io is forbidden: User "system:serviceaccount:openshift-cluster-storage-operator:csi-snapshot-webhook" cannot list resource "volumegroupsnapshotclasses" in API group "groupsnapshot.storage.k8s.io" at the cluster scope
2024-04-01T22:01:06.957954277Z W0401 22:01:06.957896 1 reflector.go:535] github.com/kubernetes-csi/external-snapshotter/client/v6/informers/externalversions/factory.go:133: failed to list *v1alpha1.VolumeGroupSnapshotClass: volumegroupsnapshotclasses.groupsnapshot.storage.k8s.io is forbidden: User "system:serviceaccount:openshift-cluster-storage-operator:csi-snapshot-webhook" cannot list resource "volumegroupsnapshotclasses" in API group "groupsnapshot.storage.k8s.io" at the cluster scope
2024-04-01T22:01:06.957954277Z E0401 22:01:06.957931 1 reflector.go:147] github.com/kubernetes-csi/external-snapshotter/client/v6/informers/externalversions/factory.go:133: Failed to watch *v1alpha1.VolumeGroupSnapshotClass: failed to list *v1alpha1.VolumeGroupSnapshotClass: volumegroupsnapshotclasses.groupsnapshot.storage.k8s.io is forbidden: User "system:serviceaccount:openshift-cluster-storage-operator:csi-snapshot-webhook" cannot list resource "volumegroupsnapshotclasses" in API group "groupsnapshot.storage.k8s.io" at the cluster scope
2024-04-01T22:01:08.994184894Z W0401 22:01:08.994132 1 reflector.go:535] github.com/kubernetes-csi/external-snapshotter/client/v6/informers/externalversions/factory.go:133: failed to list *v1alpha1.VolumeGroupSnapshotClass: volumegroupsnapshotclasses.groupsnapshot.storage.k8s.io is forbidden: User "system:serviceaccount:openshift-cluster-storage-operator:csi-snapshot-webhook" cannot list resource "volumegroupsnapshotclasses" in API group "groupsnapshot.storage.k8s.io" at the cluster scope
2024-04-01T22:01:08.994184894Z E0401 22:01:08.994162 1 reflector.go:147] github.com/kubernetes-csi/external-snapshotter/client/v6/informers/externalversions/factory.go:133: Failed to watch *v1alpha1.VolumeGroupSnapshotClass: failed to list *v1alpha1.VolumeGroupSnapshotClass: volumegroupsnapshotclasses.groupsnapshot.storage.k8s.io is forbidden: User "system:serviceaccount:openshift-cluster-storage-operator:csi-snapshot-webhook" cannot list resource "volumegroupsnapshotclasses" in API group "groupsnapshot.storage.k8s.io" at the cluster scope |
|
@Phaow How about using a new Jira bug for |
|
@duanwei33 Agree, it maybe a better option. Anyway let's wait @dobsonj 's suggestions. |
IMO, no need for a separate bug, I'll revise this PR. The webhook apparently will not start unless it has the VolumeGroupSnapshotClass permission too on 4.15. I won't add any support for VolumeGroupSnapshots in 4.15, but I believe it's harmless to allow the webhook permission to run the listers. |
|
I pushed VolumeGroupSnapshotClass permissions for the webhook as a separate commit. They are required for 4.15+ but should not be needed on prior versions. |
|
Well... even with that last change, the webhook fails with: |
|
Ok, it seems we need this change backported to 4.15 to disable the VolumeGroupSnapshot listers: |
|
/hold for openshift/csi-external-snapshotter#147 to merge first |
openshift-ci
bot
added
the
do-not-merge/hold
dobsonj
force-pushed
the
OCPBUGS-31497-4.15
branch
from
8852528
to
42d42f9
Compare
|
/jira refresh |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-ci-robot
added
jira/valid-bug
|
@dobsonj: This pull request references Jira Issue OCPBUGS-31599, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dobsonj: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
openshift/csi-external-snapshotter#147 merged but e2e-gcp-csi still shows volumegroupsnapshotclass failures, I think we have to wait until that PR makes it into a 4.15 build before we see good test results here. |
|
/label cherry-pick-approved CI looks good and check the controller operator and webhook logs works well. $ oc logs -l app=csi-snapshot-webhook --tail=-1
I0407 09:31:33.853279 1 certwatcher.go:129] Updated current TLS certificate
Starting webhook server
I0407 09:31:33.955199 1 webhook.go:214] Starting certificate watcher
I0407 09:31:37.594538 1 certwatcher.go:129] Updated current TLS certificate
Starting webhook server
I0407 09:31:37.695398 1 webhook.go:214] Starting certificate watcher |
openshift-ci
bot
added
cherry-pick-approved
|
/cherry-pick release-4.14 |
|
@dobsonj: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-bot
bot
merged commit 87d7080
into
openshift:release-4.15
|
@dobsonj: Jira Issue OCPBUGS-31599: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31599 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@dobsonj: new pull request created: #205 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-csi-snapshot-controller-operator-container-v4.15.0-202404081311.p0.g87d7080.assembly.stream.el9 for distgit ose-cluster-csi-snapshot-controller-operator. |
|
Fix included in accepted release 4.15.0-0.nightly-2024-04-16-070254 |
Manual backport of #202 to 4.15 -- but only the parts required to get the correct permissions for the webhook. We don't want any of the volumegroupsnapshot changes backported.
/cc @openshift/storage @bertinatto @Phaow