Include e2e tests #29
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huffmanca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
I'm looking to see what I'm doing incorrectly, because the PVC never binds to the PV. They get the same SC name, but there are never any events and it remains |
huffmanca
force-pushed
the
include_e2e_tests
branch
from
1db17b5
to
412b303
Compare
|
To update you on where this currently is - the tests pass, and all of the resources EXCEPT for the VolumeSnapshotContent are cleaned up after it runs. By specifying the DeletionPolicy as Retain no Finalizers are added to the VolumeSnapshot. The VolumeSnapshotContent is still having one automatically added. Scheduling the VolumeSnapshotContent for deletion and then removing the Finalizer programmatically results in being re-added. The only way I've been able to fully delete the object from the cluster is to manually remove it using The rest of the test should be straightforward. |
|
/retest |
huffmanca
force-pushed
the
include_e2e_tests
branch
from
412b303
to
a6072c7
Compare
|
This is now running and cleaning up all objects successfully, including the VolumeSnapshotContent. This PR should be ready for review. |
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
huffmanca
force-pushed
the
include_e2e_tests
branch
2 times, most recently
from
edf9ebc
to
d8d8cc8
Compare
|
/retest |
go.mod
Outdated
| k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.17.0 | ||
| k8s.io/metrics => k8s.io/metrics v0.17.0 | ||
| k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.17.0 | ||
| ) |
There was a problem hiding this comment.
Shouldn't this change be part of the "Update deps" commit instead?
Also, will we "backport" this patch to 4.4? (= cherry-pick torelease-4.4 branch)?
IMO we should have e2e tests there, but this is a rather big change (1.200+ files updated).backport all
There was a problem hiding this comment.
This should now be in the second commit.
As far as backporting goes... we probably should, but I'm not certain if it's realistic.
test/e2e/operator_test.go
Outdated
| t.Logf("Found snapshot content %v", snapshotContent.ObjectMeta.Name) | ||
|
|
||
| // Ensure the Snapshot reports ReadyToUse = true | ||
| err = waitForSnapshotReady(ctx, snapshot, t, namespace) |
There was a problem hiding this comment.
I'm wondering if we should store some data in the PV, take the snaphost, restore and check if the data is equal?
|
Should we add a make target to run this e2e test? |
huffmanca
force-pushed
the
include_e2e_tests
branch
from
d8d8cc8
to
3368f11
Compare
|
/retest |
huffmanca
force-pushed
the
include_e2e_tests
branch
from
3368f11
to
389a7a9
Compare
|
/retest |
|
/lgtm |
|
/retest |
This includes the e2e test for the CSI Snapshot Controller Operator. It creates a dummy PV, PVC, VolumeSnapshotClass, VolumeSnapshot, and then confirms that a matching VolumeSnapshotContent can be found.