New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to a newer version of library-go and external snapshotter #43
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huffmanca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
EDIT: This is now resolved by using 0.5.0-alpha, which is what the apiserver also uses. |
8f3736b
to
f4ddae6
Compare
/retest |
pkg/operator/operator_test.go
Outdated
@@ -256,7 +260,7 @@ func getDeployment(args []string, image string, modifiers ...deploymentModifier) | |||
if dep.Annotations == nil { | |||
dep.Annotations = map[string]string{} | |||
} | |||
dep.Annotations["operator.openshift.io/pull-spec"] = image | |||
addDeploymentHash(dep) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use helper func from library-go? https://github.com/openshift/library-go/blob/master/pkg/operator/resource/resourceapply/apps.go#L59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been updated.
/retest |
2 similar comments
/retest |
/retest |
_ "github.com/jteeuwen/go-bindata/go-bindata" | ||
_ "github.com/openshift/library-go/alpha-build-machinery" | ||
_ "github.com/go-bindata/go-bindata" | ||
_ "github.com/go-bindata/go-bindata/go-bindata" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be an additional go-bindata entry here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was testing this it needed both github.com/go-bindata/go-bindata
and github.com/go-bindata/go-bindata/go-bindata
to have both make
and make update
complete successfully.
I'm not certain why, as I'd assume the longer path would be sufficient.
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Updates to use a newer version of library-go, client-go, and the external snapshot controller.