Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to a newer version of library-go and external snapshotter #43

Merged
merged 3 commits into from Jul 28, 2020

Conversation

huffmanca
Copy link
Contributor

Updates to use a newer version of library-go, client-go, and the external snapshot controller.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@huffmanca huffmanca changed the title Stor383 Move to a newer version of library-go and external snapshotter Jul 16, 2020
@huffmanca
Copy link
Contributor Author

huffmanca commented Jul 16, 2020

I attempted to update the external-snapshotter, which ended up pulling go.etcd.io/etcd/v3, and there are errors when attempting to vendor this dependency. I'm still researching, as I'm a bit confused due to the build error not matching the source at the commit.

EDIT: This is now resolved by using 0.5.0-alpha, which is what the apiserver also uses.

@huffmanca huffmanca changed the title Move to a newer version of library-go and external snapshotter [WIP] Move to a newer version of library-go and external snapshotter Jul 16, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2020
@huffmanca huffmanca force-pushed the STOR383 branch 2 times, most recently from 8f3736b to f4ddae6 Compare July 17, 2020 04:08
@jsafrane
Copy link
Contributor

/retest

@@ -256,7 +260,7 @@ func getDeployment(args []string, image string, modifiers ...deploymentModifier)
if dep.Annotations == nil {
dep.Annotations = map[string]string{}
}
dep.Annotations["operator.openshift.io/pull-spec"] = image
addDeploymentHash(dep)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been updated.

@huffmanca huffmanca changed the title [WIP] Move to a newer version of library-go and external snapshotter Move to a newer version of library-go and external snapshotter Jul 17, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2020
@huffmanca
Copy link
Contributor Author

/retest

2 similar comments
@huffmanca
Copy link
Contributor Author

/retest

@huffmanca
Copy link
Contributor Author

/retest

_ "github.com/jteeuwen/go-bindata/go-bindata"
_ "github.com/openshift/library-go/alpha-build-machinery"
_ "github.com/go-bindata/go-bindata"
_ "github.com/go-bindata/go-bindata/go-bindata"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an additional go-bindata entry here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was testing this it needed both github.com/go-bindata/go-bindata and github.com/go-bindata/go-bindata/go-bindata to have both make and make update complete successfully.

I'm not certain why, as I'd assume the longer path would be sufficient.

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants