New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1905320: Add memory limit for webhook container. #67
Bug 1905320: Add memory limit for webhook container. #67
Conversation
The hook took 17 MiB in a random AWS EBS CSI driver test, rounding to 20. https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25749/pull-ci-openshift-origin-master-e2e-aws-csi/1336050483793498112
As observed in a random AWS EBS CSI driver suite https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25749/pull-ci-openshift-origin-master-e2e-aws-csi/1336050483793498112 The operator took 63MiB for whole duration of the test, rounding to 75.
@jsafrane: This pull request references Bugzilla bug 1905320, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh |
cc @openshift/storage |
@jsafrane: This pull request references Bugzilla bug 1905320, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@jsafrane: All pull requests linked via external trackers have merged: Bugzilla bug 1905320 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
And adjust CSI snapshot operator memory request. Measured in https://openshift-release.apps.ci.l2s4.p1.openshiftapps.com/releasestream/4.7.0-0.nightly/release/4.7.0-0.nightly-2020-12-04-013308:
container_memory_max_usage_bytes{container="csi-snapshot-controller-operator",..., pod="csi-snapshot-controller-operator-8555964b44-lzsxd"} 66138112
container_memory_max_usage_bytes{container="webhook", ..., pod="csi-snapshot-webhook-f7bb59b75-8wqcq"} 18132992
For the record, snapshot-controller memory requirement is OK.