Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1965263: VolumeSnapshotContents listing should print also namespace of the VolumeSnapshot ref. #93

Conversation

tsmetana
Copy link
Member

Getting the VolumeSnapshotContents from CLI will print also the VolumeSnapshot it references. This is however not sufficient to identify the correct VolumeSnapshot object since it's namespaced. This patch adds alos the namespace column to the printed information.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1965263

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@tsmetana: This pull request references Bugzilla bug 1965263, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1965263: VolumeSnapshotContents listing should print also namespace of the VolumeSnapshot ref.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 16, 2021
@openshift-ci openshift-ci bot requested review from gnufied and huffmanca June 16, 2021 10:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@tsmetana
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@tsmetana: This pull request references Bugzilla bug 1965263, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 16, 2021
@tsmetana tsmetana force-pushed the add-snapshotcontent-namespace-desc branch from b32b505 to 154819d Compare June 16, 2021 13:54
@jsafrane
Copy link
Contributor

We copy the CRDs from upstream, did you fix them there too?

@tsmetana
Copy link
Member Author

I didn't realize this. Sorry. I hope I'm attempting to fix it at the correct upstream place: kubernetes-csi/external-snapshotter#535

@tsmetana
Copy link
Member Author

tsmetana commented Jun 21, 2021

The upstream PR got merged.

@tsmetana
Copy link
Member Author

/test e2e-aws

@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b85ab87 into openshift:master Jun 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

@tsmetana: All pull requests linked via external trackers have merged:

Bugzilla bug 1965263 has been moved to the MODIFIED state.

In response to this:

Bug 1965263: VolumeSnapshotContents listing should print also namespace of the VolumeSnapshot ref.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsmetana tsmetana deleted the add-snapshotcontent-namespace-desc branch June 23, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants