New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1965263: VolumeSnapshotContents listing should print also namespace of the VolumeSnapshot ref. #93
Bug 1965263: VolumeSnapshotContents listing should print also namespace of the VolumeSnapshot ref. #93
Conversation
@tsmetana: This pull request references Bugzilla bug 1965263, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@tsmetana: This pull request references Bugzilla bug 1965263, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b32b505
to
154819d
Compare
We copy the CRDs from upstream, did you fix them there too? |
I didn't realize this. Sorry. I hope I'm attempting to fix it at the correct upstream place: kubernetes-csi/external-snapshotter#535 |
The upstream PR got merged. |
/test e2e-aws |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, tsmetana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tsmetana: All pull requests linked via external trackers have merged: Bugzilla bug 1965263 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Getting the VolumeSnapshotContents from CLI will print also the VolumeSnapshot it references. This is however not sufficient to identify the correct VolumeSnapshot object since it's namespaced. This patch adds alos the namespace column to the printed information.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1965263