Bug 1826885: DNS Service Monitor & Daemonset fixes

[sgreene570]

Fixes the potential for a false positive unit test in pkg/operator/controller/controller_service_monitor_test.go.
Also adds the kube-rbac-proxy name to the DNS daemonset config changed function, as well as corresponding unit test.

[openshift-ci-robot]

@sgreene570: This pull request references Bugzilla bug 1826885, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1826885: DNS Service Monitor & Daemonset fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@sgreene570: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 1826885 DNS Service Monitor & Daemonset fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sgreene570]

/bugzilla refresh

[Miciah]

Thanks! Sorry I didn't catch this when reviewing #163. Failing to update the kube-rbac-proxy image would be bad, especially if there were a security update to the kube-rbac-proxy image in 4.5.z.

/lgtm

[openshift-ci-robot]

@sgreene570: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@sgreene570: This pull request references Bugzilla bug 1826885, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1826885: DNS Service Monitor & Daemonset fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sgreene570: All pull requests linked via external trackers have merged: openshift/cluster-dns-operator#170. Bugzilla bug 1826885 has been moved to the MODIFIED state.

In response to this:

Bug 1826885: DNS Service Monitor & Daemonset fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.