New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1882323: Fix operator namespace in clusteroperator related resources #200
Bug 1882323: Fix operator namespace in clusteroperator related resources #200
Conversation
The dns cluster operator is fed the DNS operator's namespace in pkg/operator/controller/status/controller.go. This commit fixes a regression brought in by openshift#187 in which the cluster operator is given a reference to the "dns" namespace, which does not exist. This commit instead gives the cluster operator a reference to the correct operator namespace set at run time.
@sgreene570: This pull request references Bugzilla bug 1882323, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@sgreene570: This pull request references Bugzilla bug 1882323, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sgreene570: This pull request references Bugzilla bug 1882323, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@sgreene570: This pull request references Bugzilla bug 1882323, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sgreene570 can you update the e2e test so that it compares current>expected status related objects? It would be nice to avoid running into this again in the future. |
Test the co.Status.RelatedObjects field to make sure that the DNS names are configured properly by the operator.
@danehans good idea. Commit |
/retest |
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sgreene570: All pull requests linked via external trackers have merged: Bugzilla bug 1882323 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The dns cluster operator is fed the DNS operator's namespace in pkg/operator/controller/status/controller.go. This commit fixes a regression brought in by #187 in which the cluster operator is given a reference to the "dns" namespace, which does not exist. This commit instead gives the cluster operator a reference to the correct operator namespace set at run time.
This regression affects must-gather, but could also have potentially unknown consequences since the cluster operator resource is pointing to a nil namespace.