Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add current profile annotations to CVO manifests #206

Merged
merged 1 commit into from Oct 26, 2020

Conversation

guillaumerose
Copy link
Contributor

This is matches openshift/enhancements#510 and doesn't change existing behavior

This is matches openshift/enhancements#510 and doesn't change existing behavior
@frobware
Copy link
Contributor

Was the go mod bump due to switching from apiextensions.k8s.io/v1beta1 to apiextensions.k8s.io/v1? (otherwise LGTM, but curious about the bump)

@guillaumerose
Copy link
Contributor Author

The openshift/api bumped is required because some CRD manifests are in (DNS CRD here).
https://github.com/openshift/api/blob/master/operator/v1/0000_70_dns-operator_00-custom-resource-definition.yaml#L6

The annotation needs to be on both sides.

@frobware
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, guillaumerose

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit d014567 into openshift:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants