Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1928304: Set CoreDNS readiness probe period and timeout each to 3 seconds #235

Merged
merged 2 commits into from Mar 1, 2021
Merged

[release-4.7] Bug 1928304: Set CoreDNS readiness probe period and timeout each to 3 seconds #235

merged 2 commits into from Mar 1, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #234

/assign Miciah

@Miciah
Set CoreDNS readiness probe period and timeout to 3
89ed1af 
Change the readiness probe for CoreDNS from using a 10-second period and
timeout to using a 3-second period and timeout in order to reduce the time
to remove the endpoint if CoreDNS becomes unresponsive.

This commit is related to bug 1919737.

https://bugzilla.redhat.com/show_bug.cgi?id=1919737

* assets/dns/daemonset.yaml: Set readiness probe period and timeout to 3
seconds.
* pkg/manifests/bindata.go: Regenerate.
@Miciah
Reconcile all readiness probe parameters
200ba2c 
Check all parameters of the CoreDNS daemonset's readiness probe, and update
the daemonset if any of the probe's parameters differ from the expected
values.

Before this commit, the DNS controller only reconciled the readiness
probe's handler and ignored changes to other parameters of the probe.

* pkg/operator/controller/controller_dns_daemonset.go
(daemonsetConfigChanged): Check if any of the readiness probe's parameters
changed and update them if they did.
* pkg/operator/controller/controller_dns_daemonset_test.go
(TestDaemonsetConfigChanged): Add test case to verify that
daemonsetConfigChanged detects changes to the readiness probe's
periodSeconds parameter.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 12, 2021
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1919737 has been cloned as Bugzilla bug 1928304. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1928304: Set CoreDNS readiness probe period and timeout each to 3 seconds

In response to this:

[release-4.7] Bug 1919737: Set CoreDNS readiness probe period and timeout each to 3 seconds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1919737: Set CoreDNS readiness probe period and timeout each to 3 seconds [release-4.7] Bug 1928304: Set CoreDNS readiness probe period and timeout each to 3 seconds Feb 12, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 12, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1928304, which is invalid:

  • expected dependent Bugzilla bug 1919737 to be in one of the following states: MODIFIED, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1928304: Set CoreDNS readiness probe period and timeout each to 3 seconds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sgreene570
Copy link
Contributor

/retest

@Miciah
Copy link
Contributor

Miciah commented Feb 15, 2021

The e2e-aws CI job failed with no obvious DNS-related issues. The last test run's pods.json fiile shows one DNS pod did not become ready, but the nodes.json file shows that the problem was that the hosting node did not become ready.

@Miciah
Copy link
Contributor

Miciah commented Feb 19, 2021

/test e2e-aws

@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 25, 2021
Merged
@Miciah
Copy link
Contributor

Miciah commented Feb 25, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Bugzilla bug 1928304, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1919737 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1919737 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 25, 2021
@Miciah
Copy link
Contributor

Miciah commented Feb 25, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit b37ee15 into openshift:release-4.7 Mar 1, 2021
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1928304 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1928304: Set CoreDNS readiness probe period and timeout each to 3 seconds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candita candita Awaiting requested review from candita

@sgreene570 sgreene570 Awaiting requested review from sgreene570

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @sgreene570 @Miciah @mrunalp @openshift-merge-robot