Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.6] Bug 1928773: Set CoreDNS readiness probe period and timeout each to 3 seconds #236

Commits on Feb 15, 2021

  1. Set CoreDNS readiness probe period and timeout to 3

    Change the readiness probe for CoreDNS from using a 10-second period and
    timeout to using a 3-second period and timeout in order to reduce the time
    to remove the endpoint if CoreDNS becomes unresponsive.
    
    This commit is related to bug 1928773.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1928773
    
    * assets/dns/daemonset.yaml: Set readiness probe period and timeout to 3
    seconds.
    * pkg/manifests/bindata.go: Regenerate.
    Miciah committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    62c4ff7 View commit details
    Browse the repository at this point in the history
  2. Reconcile all readiness probe parameters

    Check all parameters of the CoreDNS daemonset's readiness probe, and update
    the daemonset if any of the probe's parameters differ from the expected
    values.
    
    Before this commit, the DNS controller ignored all changes to the readiness
    probe's parameters.
    
    * pkg/operator/controller/controller_dns_daemonset.go
    (daemonsetConfigChanged): Check if any of the readiness probe's parameters
    changed and update them if they did.
    * pkg/operator/controller/controller_dns_daemonset_test.go
    (TestDaemonsetConfigChanged): Add test case to verify that
    daemonsetConfigChanged detects changes to the readiness probe's
    path or periodSeconds parameters.
    Miciah committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    0c8cd6b View commit details
    Browse the repository at this point in the history