Bug 1935297: Set CoreDNS readiness probe period and timeout each to 3 seconds #242
Conversation
Change the readiness probe for CoreDNS from using a 10-second period and timeout to using a 3-second period and timeout in order to reduce the time to remove the endpoint if CoreDNS becomes unresponsive. This commit is related to bug 1928773. https://bugzilla.redhat.com/show_bug.cgi?id=1928773 * assets/dns/daemonset.yaml: Set readiness probe period and timeout to 3 seconds. * pkg/manifests/bindata.go: Regenerate.
Check all parameters of the CoreDNS daemonset's readiness probe, and update the daemonset if any of the probe's parameters differ from the expected values. Before this commit, the DNS controller ignored all changes to the readiness probe's parameters. * pkg/operator/controller/controller_dns_daemonset.go (daemonsetConfigChanged): Check if any of the readiness probe's parameters changed and update them if they did. * pkg/operator/controller/controller_dns_daemonset_test.go (TestDaemonsetConfigChanged): Add test case to verify that daemonsetConfigChanged detects changes to the readiness probe's path or periodSeconds parameters.
openshift-ci-robot
added
bugzilla/severity-high
|
@Miciah: This pull request references Bugzilla bug 1935297, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knobunc, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@knobunc: This pull request references Bugzilla bug 1935297, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
removed
the
bugzilla/severity-high
|
@knobunc: This pull request references Bugzilla bug 1935297, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/severity-urgent
crawford
changed the title
crawford
added
the
cherry-pick-approved
|
/retest |
|
@Miciah: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1935297 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a manual cherry-pick of #234. This cherry-pick also includes parts of #205 that #213 did not revert and that #234 builds upon.
Set CoreDNS readiness probe period and timeout to 3
Change the readiness probe for CoreDNS from using a 10-second period and timeout to using a 3-second period and timeout in order to reduce the time to remove the endpoint if CoreDNS becomes unresponsive.
assets/dns/daemonset.yaml: Set readiness probe period and timeout to 3 seconds.pkg/manifests/bindata.go: Regenerate.Reconcile all readiness probe parameters
Check all parameters of the CoreDNS daemonset's readiness probe, and update the daemonset if any of the probe's parameters differ from the expected values.
Before this commit, the DNS controller ignored all changes to the readiness probe's parameters.
pkg/operator/controller/controller_dns_daemonset.go(daemonsetConfigChanged): Check if any of the readiness probe's parameters changed and update them if they did.pkg/operator/controller/controller_dns_daemonset_test.go(TestDaemonsetConfigChanged): Add test case to verify thatdaemonsetConfigChangeddetects changes to the readiness probe'spathorperiodSecondsparameters.