[release-4.7] Bug 1943826: Corefile: Use 30 second max TTL for caching of negative responses #254
Conversation
Commit 066b3f7 bumped the max TTL for records in the CoreDNS cache to 900 seconds, including negative DNS responses such as NXDOMAIN. This max TTL applies to responses received from the cluster's upstream resolver. This commit fixes bug 1943578 by lowering the CoreDNS cache max TTL for negative DNS responses to 30 seconds (while maintaining the new 900 second max TTL for positive responses). Note that `9984` is the default cache size. See https://coredns.io/plugins/cache/ for more context. This commit resolves https://bugzilla.redhat.com/show_bug.cgi?id=1943578. pkg/operator/controller/controller_dns_configmap.go: Configure the cache plugin with a 900 second TTL for positive records and 30 second TTL for negative records in the CoreDNS Corefile. pkg/operator/controller/controller_dns_configmap_test.go: Update Corefile unit tests.
|
@openshift-cherrypick-robot: Bugzilla bug 1943578 has been cloned as Bugzilla bug 1943826. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1943826, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/cherry-pick release-4.6 |
|
@Miciah: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
lgtm
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1943826, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1943826, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@sgreene570: This pull request references Bugzilla bug 1943826, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
removed
the
bugzilla/severity-high
|
@sgreene570: This pull request references Bugzilla bug 1943826, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/severity-urgent
|
/bugzilla cc-qa |
|
@quarterpin: This pull request references Bugzilla bug 1943826, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm Verified via pre-merge verification workflow, more reference related to the test can be found in: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, openshift-cherrypick-robot, quarterpin, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label qe-approved |
openshift-ci-robot
added
the
qe-approved
markmc
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1943826 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: new pull request created: #256 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #253
/assign Miciah