Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: Watch clusteroperators #261

Merged

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Apr 8, 2021

Add a watch on clusteroperators in the status controller so that it updates or recreates the dns clusteroperator as necessary should something else update or delete it.

  • pkg/operator/controller/status/controller.go (New): Watch clusteroperators with a map function and predicate to reconcile dnses.operator.openshift.io/default if clusteroperators.config.openshift.io/dns is updated.
  • test/e2e/operator_test.go (TestOperatorRecreatesItsClusterOperator): New test. Verify that the operator recreates the "dns" clusteroperator if the clusteroperator is deleted.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2021
@Miciah Miciah force-pushed the status-watch-clusteroperators branch from f8b0031 to 6fbdade Compare April 8, 2021 23:55
Add a watch on clusteroperators in the status controller so that it updates
or recreates the dns clusteroperator as necessary should something else
update or delete it.

* manifests/0000_70_dns-operator_00-cluster-role.yaml: Allow the operator
to list and watch clusteroperators.
* pkg/operator/controller/status/controller.go (New): Watch
clusteroperators with a map function and predicate to reconcile
dnses.operator.openshift.io/default if
clusteroperators.config.openshift.io/dns is updated.
* test/e2e/operator_test.go (TestOperatorRecreatesItsClusterOperator): New
test.  Verify that the operator recreates the "dns" clusteroperator if the
clusteroperator is deleted.
@Miciah
Copy link
Contributor Author

Miciah commented Jul 19, 2021

Rebased.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2021
@Miciah Miciah force-pushed the status-watch-clusteroperators branch from 6fbdade to 4a37735 Compare July 19, 2021 14:47
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2021
@frobware
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants