New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status: Watch clusteroperators #261
status: Watch clusteroperators #261
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f8b0031
to
6fbdade
Compare
Add a watch on clusteroperators in the status controller so that it updates or recreates the dns clusteroperator as necessary should something else update or delete it. * manifests/0000_70_dns-operator_00-cluster-role.yaml: Allow the operator to list and watch clusteroperators. * pkg/operator/controller/status/controller.go (New): Watch clusteroperators with a map function and predicate to reconcile dnses.operator.openshift.io/default if clusteroperators.config.openshift.io/dns is updated. * test/e2e/operator_test.go (TestOperatorRecreatesItsClusterOperator): New test. Verify that the operator recreates the "dns" clusteroperator if the clusteroperator is deleted.
Rebased. |
6fbdade
to
4a37735
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Add a watch on clusteroperators in the status controller so that it updates or recreates the dns clusteroperator as necessary should something else update or delete it.
pkg/operator/controller/status/controller.go
(New
): Watch clusteroperators with a map function and predicate to reconcilednses.operator.openshift.io/default
ifclusteroperators.config.openshift.io/dns
is updated.