New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.7] Bug 1953609: Enable errors plugin for custom upstream resolvers #268
[release-4.7] Bug 1953609: Enable errors plugin for custom upstream resolvers #268
Conversation
Before this commit, the operator did not enable the "errors" plugin in server blocks for custom upstream resolvers. As a consequence, failures from upstream resolvers were not logged. This commit enables the errors plugin for all server blocks. This commit fixes bug 1934905. https://bugzilla.redhat.com/show_bug.cgi?id=1934905 * pkg/operator/controller/controller_dns_configmap.go (corefileTemplate): Add the errors plugin to server blocks for custom upstream resolvers. * pkg/operator/controller/controller_dns_configmap_test.go (TestDesiredDNSConfigmap): Update to expect the errors plugin in all server blocks.
@openshift-cherrypick-robot: Bugzilla bug 1934905 has been cloned as Bugzilla bug 1953609. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1953609, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jechen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/cherry-pick release-4.6 |
Thanks! |
@sgreene570: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, openshift-cherrypick-robot, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh |
@sgreene570: This pull request references Bugzilla bug 1953609, which is valid. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jechen@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ideally this would merge into the same z stream as #267 |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1953609 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sgreene570: new pull request created: #271 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #241
/assign sgreene570