OCPBUGS-23741: Bump to k8s.io v0.28.3, controller-runtime v0.16.3 #395
Conversation
Bump the vendored k8s.io/* packages to v0.28.3. Bump
sigs.k8s.io/controller-runtime package to v0.16.3, the latest release,
which uses the k8s.io/* v0.28.3 packages.
go get k8s.io/api@v0.28.3 k8s.io/apimachinery@v0.28.3 k8s.io/client-go@v0.28.3 k8s.io/kubectl@v0.28.3 sigs.k8s.io/controller-runtime@v0.16.3
go mod tidy
go mod vendor
This commit fixes OCPBUGS-23741.
https://issues.redhat.com/browse/OCPBUGS-23741
* go.mod: Bump.
* go.sum: Regenerate.
* cmd/dns-operator/main.go (main): Update to get DefaultBindAddress from
sigs.k8s.io/controller-runtime/pkg/metrics/server instead of from
sigs.k8s.io/controller-runtime/pkg/metrics.
* pkg/operator/operator.go (New): Update to use the new DefaultNamespaces
field instead of Namespaces, which has been removed from the manager
options.
* vendor/*: Regenerate.
openshift-ci-robot
added
jira/severity-important
|
@Miciah: This pull request references Jira Issue OCPBUGS-23741, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@Miciah: This pull request references Jira Issue OCPBUGS-23741, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@Miciah: Jira Issue OCPBUGS-23741: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-23741 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-dns-operator-container-v4.15.0-202311300249.p0.gda2a4b8.assembly.stream for distgit ose-cluster-dns-operator. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536 |
Bump the vendored k8s.io/* packages to v0.28.3. Bump sigs.k8s.io/controller-runtime package to v0.16.3, the latest release, which uses the k8s.io/* v0.28.3 packages.
go.mod: Bump.go.sum: Regenerate.cmd/dns-operator/main.go(main): Update to getDefaultBindAddressfrom sigs.k8s.io/controller-runtime/pkg/metrics/server instead of from sigs.k8s.io/controller-runtime/pkg/metrics.pkg/operator/operator.go(New): Update to use the newDefaultNamespacesfield instead ofNamespaces, which has been removed from the manager options.vendor/*: Regenerate.