Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifests: Add ClusterOperator resource #74

Merged
merged 1 commit into from
Feb 9, 2019
Merged

manifests: Add ClusterOperator resource #74

merged 1 commit into from
Feb 9, 2019

Conversation

ironcladlou
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 6, 2019
Miciah
Miciah reviewed Feb 6, 2019
View reviewed changes
manifests/0000_08_cluster_operator.yaml Outdated
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
name: ingress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad copypasta!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bootstrap-complete timed out, presumably because it was looking for the "ingress" clusteroperator instead of "dns".

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, should be dns

@ironcladlou ironcladlou changed the title manifests: Add ClusterOperator resource WIP: manifests: Add ClusterOperator resource Feb 6, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2019
pravisankar
pravisankar suggested changes Feb 7, 2019
View reviewed changes
manifests/0000_08_cluster_operator.yaml Outdated
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
name: ingress
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, should be dns

@ironcladlou ironcladlou changed the title WIP: manifests: Add ClusterOperator resource manifests: Add ClusterOperator resource Feb 7, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2019
@Miciah
Copy link
Contributor

Miciah commented Feb 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
pravisankar
pravisankar approved these changes Feb 7, 2019
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ramr
ramr approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@ramr ramr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, Miciah, pravisankar, ramr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Miciah,ironcladlou,pravisankar,ramr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ironcladlou
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c9fa6a1 into openshift:master Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miciah Miciah Miciah left review comments

@ramr ramr ramr approved these changes

@pravisankar pravisankar pravisankar approved these changes

Assignees

@pravisankar pravisankar

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ironcladlou @Miciah @openshift-ci-robot @openshift-bot @ramr @pravisankar @openshift-merge-robot