add an init container to stop the pod with bad revision

bindata/etcd/pod.yaml

@@ -10,6 +10,29 @@ metadata:
     revision: "REVISION"
 spec:
   initContainers:
+    - name: etcd-ensure-env-vars
+      image: ${IMAGE}
+      imagePullPolicy: IfNotPresent
+      terminationMessagePolicy: FallbackToLogsOnError
+      command:
+        - /bin/sh
+        - -c
+        - |
+          #!/bin/sh
+          set -euo pipefail
+
+          : "${NODE_NODE_ENVVAR_NAME_ETCD_URL_HOST?not set}"
+          : "${NODE_NODE_ENVVAR_NAME_ETCD_NAME?not set}"
+          : "${NODE_NODE_ENVVAR_NAME_IP?not set}"
+
+      resources:
+        requests:
+          memory: 60Mi
+          cpu: 30m
+      securityContext:
+        privileged: true
+      env:
+      ${COMPUTED_ENV_VARS}
     - name: etcd-resources-copy
       image: ${IMAGE}
       imagePullPolicy: IfNotPresent

pkg/operator/clustermembercontroller/clustermembercontroller.go

@@ -220,6 +220,13 @@ func (c *ClusterMemberController) getEtcdPodToAddToMembership() (*corev1.Pod, er
 			continue
 		}
 
+		// if pod is not initialized we dont know the env is correct
+		for _, cond := range pod.Status.Conditions {
+			if cond.Type == corev1.PodInitialized && cond.Status == corev1.ConditionFalse {
+				continue
+			}
+		}
+
 		// check to see if this member is updating from 4.3
 		etcdMember, err := c.etcdClient.GetMember("etcd-member-" + pod.Spec.NodeName)
 		switch {