Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resource removal by CVO #1017

Conversation

Elbehery
Copy link
Contributor

@Elbehery Elbehery commented Mar 3, 2023

This PR documents how CEO uses release.openshift.io/delete: "true" annotation to garbage collect resources

e.g. #1016

@openshift-ci openshift-ci bot requested review from hasbro17 and tjungblu March 3, 2023 10:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2023
@Elbehery Elbehery force-pushed the update-doc-resource-removal-cvo branch from 6b6392e to 297c70d Compare March 3, 2023 10:59
@tjungblu
Copy link
Contributor

tjungblu commented Mar 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2023
@Elbehery Elbehery force-pushed the update-doc-resource-removal-cvo branch from 297c70d to ce39d90 Compare March 3, 2023 11:04
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2023
docs/HACKING.md Outdated
@@ -1,4 +1,4 @@
⚠⚠⚠ THIS IS A LIVING DOCUMENT AND LIKELY TO CHANGE QUICKLY ⚠⚠⚠
s⚠⚠⚠ THIS IS A LIVING DOCUMENT AND LIKELY TO CHANGE QUICKLY ⚠⚠⚠
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s? 🤣

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorryyyy :D :D

@Elbehery
Copy link
Contributor Author

Elbehery commented Mar 3, 2023

/retest-required

@Elbehery Elbehery force-pushed the update-doc-resource-removal-cvo branch from ce39d90 to 89e82da Compare March 3, 2023 14:08
@tjungblu
Copy link
Contributor

tjungblu commented Mar 3, 2023

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

@Elbehery: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7bb6221 into openshift:master Mar 3, 2023
@Elbehery Elbehery deleted the update-doc-resource-removal-cvo branch February 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants