Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-14255: Add Controller health to CEO liveness probe #1049

Merged
merged 1 commit into from Jun 16, 2023
Merged

OCPBUGS-14255: Add Controller health to CEO liveness probe #1049

merged 1 commit into from Jun 16, 2023

Conversation

tjungblu
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 25, 2023
@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-12475, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dusk125 and Elbehery April 25, 2023 11:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2023
@tjungblu tjungblu mentioned this pull request Apr 25, 2023
Closed
@tjungblu
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

@tjungblu
Copy link
Contributor Author

/test e2e-metal-single-node-live-iso

@tjungblu
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

/test e2e-metal-single-node-live-iso

@tjungblu
Copy link
Contributor Author

/test e2e-metal-single-node-live-iso

@tjungblu
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2023
@tjungblu
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

/test e2e-metal-single-node-live-iso

@tjungblu
Copy link
Contributor Author

/retest-required

@tjungblu tjungblu mentioned this pull request Apr 25, 2023
Merged
@tjungblu
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

/test e2e-metal-single-node-live-iso

@tjungblu
Copy link
Contributor Author

/test e2e-aws-ovn-single-node

/test e2e-metal-single-node-live-iso

@tjungblu tjungblu changed the title OCPBUGS-12475: ensure health check runs despite lost leadership ensure health check runs despite lost leadership Apr 26, 2023
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 26, 2023
@openshift-ci-robot
Copy link

@tjungblu: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2023
@tjungblu
Copy link
Contributor Author

did some extra checks against 4.13 and SNOs, works very well with the new aliveness check. No unnecessary restarts and leader locks anymore.

@dusk125
Copy link
Contributor

dusk125 commented Apr 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 30, 2023
@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-14255, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from geliu2016 May 30, 2023 09:16
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0155625 and 2 for PR HEAD 569b7e6 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD eaab549 and 1 for PR HEAD 569b7e6 in total

@tjungblu
Copy link
Contributor Author

/retest-required

1 similar comment
@Elbehery
Copy link
Contributor

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023
geliu2016
geliu2016 approved these changes May 31, 2023
View reviewed changes
Copy link

@geliu2016 geliu2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 31, 2023
@tjungblu
OCPBUGS-12475: ensure health check runs despite lost leadership
9741ca6 
This is done by adding the health check to the already existing
webserver, which is also serving metrics. This also updates library-go
to consume the new optional for adding health checks.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023
@tjungblu
Copy link
Contributor Author

/retest-required

@tjungblu
Copy link
Contributor Author

/retest

@dusk125
Copy link
Contributor

dusk125 commented May 31, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, geliu2016, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tjungblu
Copy link
Contributor Author

/hold

gotta see how this influences the recovery tests :/

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2023
@tjungblu
Copy link
Contributor Author

/retest

@tjungblu
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d7d5425 and 2 for PR HEAD 9741ca6 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@tjungblu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c39f469 into openshift:master Jun 16, 2023
13 checks passed
@openshift-ci-robot
Copy link

@tjungblu: Jira Issue OCPBUGS-14255: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14255 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@tjungblu: #1049 failed to apply on top of branch "release-4.13":

Applying: OCPBUGS-12475: ensure health check runs despite lost leadership
Using index info to reconstruct a base tree...
M	manifests/0000_20_etcd-operator_06_deployment.yaml
M	pkg/operator/starter.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/starter.go
CONFLICT (content): Merge conflict in pkg/operator/starter.go
Auto-merging manifests/0000_20_etcd-operator_06_deployment.yaml
CONFLICT (content): Merge conflict in manifests/0000_20_etcd-operator_06_deployment.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-12475: ensure health check runs despite lost leadership
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geliu2016 geliu2016 geliu2016 approved these changes

@dusk125 dusk125 Awaiting requested review from dusk125

@Elbehery Elbehery Awaiting requested review from Elbehery

Assignees

@dusk125 dusk125

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tjungblu @openshift-ci-robot @dusk125 @openshift-cherrypick-robot @Elbehery @geliu2016 @openshift-merge-robot