Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-13547: Remove featureset flag and use only the manifest #1054

Merged
merged 1 commit into from May 30, 2023

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented May 10, 2023

The manifest now exists in every install and can be used by bootstrapping. The installer passes the arg now, so we can update the operator to only honor the manifest and eliminate interpretation.

peer to openshift/cluster-kube-apiserver-operator#1491

This also updates to the latest kube.

@openshift-ci openshift-ci bot requested review from hasbro17 and tjungblu May 10, 2023 20:47
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@tjungblu
Copy link
Contributor

@deads2k build complains about note: module requires Go 1.20

@deads2k
Copy link
Contributor Author

deads2k commented May 15, 2023

@deads2k build complains about note: module requires Go 1.20

yeah, I expected to see an ART PR here to merge.

@tjungblu
Copy link
Contributor

@deads2k feel free to hit the merge button on #1047

@deads2k
Copy link
Contributor Author

deads2k commented May 18, 2023

/test all

@hasbro17
Copy link
Contributor

Scaling test is good, just a disruption test that it's flaking on:

kube-api-reused-connections was unreachable during disruption testing for at least 1s of 32m25s (maxAllowed=0s):

/override ci/prow/e2e-aws-ovn-etcd-scaling

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

@hasbro17: Overrode contexts on behalf of hasbro17: ci/prow/e2e-aws-ovn-etcd-scaling

In response to this:

Scaling test is good, just a disruption test that it's flaking on:

kube-api-reused-connections was unreachable during disruption testing for at least 1s of 32m25s (maxAllowed=0s):

/override ci/prow/e2e-aws-ovn-etcd-scaling

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hasbro17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 30, 2023
@deads2k deads2k changed the title Remove featureset flag and use only the manifest OCPBUGS-13547: Remove featureset flag and use only the manifest May 30, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 30, 2023
@openshift-ci-robot
Copy link

@deads2k: This pull request references Jira Issue OCPBUGS-13547, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The manifest now exists in every install and can be used by bootstrapping. The installer passes the arg now, so we can update the operator to only honor the manifest and eliminate interpretation.

peer to openshift/cluster-kube-apiserver-operator#1491

This also updates to the latest kube.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor Author

deads2k commented May 30, 2023

cleaning up the remnants for external cloud provider

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 May 30, 2023 17:29
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 703ae29 into openshift:master May 30, 2023
12 checks passed
@openshift-ci-robot
Copy link

@deads2k: Jira Issue OCPBUGS-13547: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-13547 has not been moved to the MODIFIED state.

In response to this:

The manifest now exists in every install and can be used by bootstrapping. The installer passes the arg now, so we can update the operator to only honor the manifest and eliminate interpretation.

peer to openshift/cluster-kube-apiserver-operator#1491

This also updates to the latest kube.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants