Revert "Integrate feature flags in CEO"

[DennisPeriquet]

Reverts #1062

Per Openshift policy we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This change is breaking

• 4.14 CI payload: 4.14.0-0.ci-2023-07-08-062054
• 4.14 nightly payload: 4.14.0-0.nightly-2023-07-08-161537

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of to confirm the fix has corrected the problem:

/payload 4.14 nightly blocking
/payload 4.14 nightly ci

Since this PR was introduced, 4.14.0-0.ci-2023-07-08-062054 and 4.14.0-0.nightly-2023-07-08-161537 have gotten this failure:

Failed: suite=[openshift-tests-upgrade], [sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers

Given a sample failure like this and logs like this:

E0708 09:38:50.892701       1 simple_featuregate_reader.go:290] cluster failed with : unable to determine features: missing desired version "4.13.0-0.ci-2023-07-07-163417" in featuregates.config.openshift.io/cluster

I believe this PR is the cause.

cc @tjungblu

[neisw]

/payload-job periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade

[openshift-ci]

@neisw: trigger 1 job(s) for the /payload-(job|aggregate) command

• periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b0eb1a70-1eac-11ee-9d1f-c54b40efe694-0

[tjungblu]

Thanks, let's get this in for now - I'll revise this later.

[tjungblu]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tjungblu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tjungblu]

/override ci/prow/e2e-aws-ovn-etcd-scaling

[openshift-ci]

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-etcd-scaling

In response to this:

/override ci/prow/e2e-aws-ovn-etcd-scaling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@DennisPeriquet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-etcd-recovery	7038223	link	false	/test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tjungblu]

fix found in #1071