MON-669: Add etcd ServiceMonitor, before that was managed by cluster-… #1070
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@machine424: This pull request references MON-669 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
…w managed by cluster-etcd-operator. See openshift/cluster-etcd-operator#1070
…w managed by cluster-etcd-operator. See openshift/cluster-etcd-operator#1070
|
/retest |
| }, | ||
| (&resourceapply.ClientHolder{}).WithKubernetes(kubeClient), | ||
| operatorClient, | ||
| controllerContext.EventRecorder, | ||
| ).AddKubeInformers(kubeInformersForNamespaces) | ||
| ).WithIgnoreNotFoundOnCreate().AddKubeInformers(kubeInformersForNamespaces) |
There was a problem hiding this comment.
In case the CRD isn't there
(NotFound errors are reported in <name>Degraded condition, but with Degraded=false. )
|
@machine424: This pull request references MON-669 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| kind: ServiceMonitor | ||
| metadata: | ||
| name: etcd | ||
| namespace: openshift-etcd-operator |
There was a problem hiding this comment.
don't know if it's ok to deploy resources on operator namespace
(still think this makes more sense on openshift-etcd ns, but your call)
…w managed by cluster-etcd-operator. See openshift/cluster-etcd-operator#1070
machine424
force-pushed
the
smon
branch
3 times, most recently
from
8a1103b
to
e4a96c4
Compare
|
/retest |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
…w managed by cluster-etcd-operator. See openshift/cluster-etcd-operator#1070
|
/approve /retest |
openshift-ci
bot
added
the
approved
|
/override ci/prow/e2e-aws-ovn-etcd-scaling LGTM whenever the nits from @tjungblu are addressed. |
|
@hasbro17: Overrode contexts on behalf of hasbro17: ci/prow/e2e-aws-ovn-etcd-scaling In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…naged by cluster-monitoring-operator. See openshift/cluster-monitoring-operator#2039 Check this https://docs.openshift.com/container-platform/4.13/monitoring/configuring-the-monitoring-stack.html#configuring-metrics-collection-profiles_configuring-the-monitoring-stack for the reason behind having two ServiceMonitors
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: machine424, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@machine424: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit 5979f3b
into
openshift:master
…w managed by cluster-etcd-operator. See openshift/cluster-etcd-operator#1070
No description provided.