Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rev bumps and etcdutl #1072

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

tjungblu
Copy link
Contributor

@tjungblu tjungblu commented Jul 11, 2023

This PR will:

  • use etcdutl when available, to ease the eventual transition towards 3.6
  • add a rev bump by 1 billion and mark compacted to test the feature in our CI restore job, flagged off by default

@openshift-ci openshift-ci bot requested review from dusk125 and hasbro17 July 11, 2023 11:04
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@tjungblu
Copy link
Contributor Author

/retest

@tjungblu
Copy link
Contributor Author

/hold

still figuring out what makes most sense

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023
@tjungblu
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2023
@dusk125
Copy link
Contributor

dusk125 commented Jul 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tjungblu
Copy link
Contributor Author

/retest

@tjungblu
Copy link
Contributor Author

/override e2e-aws-etcd-recovery

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

@tjungblu: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-aws-etcd-recovery

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-agnostic-ovn
  • ci/prow/e2e-agnostic-ovn-upgrade
  • ci/prow/e2e-aws-etcd-recovery
  • ci/prow/e2e-aws-ovn-etcd-scaling
  • ci/prow/e2e-aws-ovn-serial
  • ci/prow/e2e-aws-ovn-single-node
  • ci/prow/e2e-operator
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-agnostic-ovn
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-agnostic-ovn-upgrade
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-etcd-recovery
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-etcd-scaling
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-operator
  • pull-ci-openshift-cluster-etcd-operator-master-images
  • pull-ci-openshift-cluster-etcd-operator-master-unit
  • pull-ci-openshift-cluster-etcd-operator-master-verify
  • pull-ci-openshift-cluster-etcd-operator-master-verify-deps
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-aws-etcd-recovery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor Author

/override ci/prow/e2e-aws-etcd-recovery

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-etcd-recovery

In response to this:

/override ci/prow/e2e-aws-etcd-recovery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5979f3b and 2 for PR HEAD 6f4c6b1 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

@tjungblu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit a662347 into openshift:master Jul 17, 2023
12 checks passed
dusk125 pushed a commit to dusk125/cluster-etcd-operator that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants