add pvc validation and e2e tests #1096
Conversation
openshift-ci
bot
added
the
approved
|
nice work 👍🏽 would it make sense to attempt to create the PVC by the controller in case it does not exist ? |
|
Thanks
if you tell me how many gigabytes and which storage class are needed for all our 150 different cloud and deployment configurations, please :) |
|
/test ci/prow/e2e-operator |
|
@tjungblu: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-operator |
|
|
||
| if !valid { | ||
| klog.V(4).Infof("BackupController deems: %v invalid, skipping", backupsToRun[0]) | ||
| return nil |
There was a problem hiding this comment.
so if the backup is invalid, we just log it, no err returned
the next sync() it will be the same, or ?
There was a problem hiding this comment.
no, because the backup failure state is set on the CRD, no need to degrade the operator in this case
|
/lgtm |
|
/retest-required |
tjungblu
force-pushed
the
backup_pvc_missing
branch
from
7bf650e
to
ce9a06e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elbehery, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tjungblu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit e7af656
into
openshift:master
When we create a backup for a pvc that doesn't exist the pod will just be stuck in Pending state forever. This PR introduces validation for it and marks the backup as failed before spawning a pod.