OCPBUGS-19378: [4.13] Backports of backup/restore fixes #1117

tjungblu · 2023-09-20T11:28:14Z

No description provided.

* ETCD-484: add e2e backup debug pod * poll debug pod * bump sleep interval * bump timeout duration * specify default namespace for debug pod * fix debug pod name logic * inline backup name * fix files assertion --------- Co-authored-by: Mustafa Elbehery <melbeher@redhat.com>

openshift-ci-robot · 2023-09-20T11:28:18Z

@tjungblu: This pull request references Jira Issue OCPBUGS-19378, which is invalid:

expected Jira Issue OCPBUGS-19378 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery · 2023-09-20T11:32:04Z

/lgtm
/approve

tjungblu · 2023-09-20T11:34:47Z

/hold

also waiting for #1113 to land

tjungblu · 2023-09-20T13:36:27Z

seems there's some pod security issue in 4.13:

   	            	Original error:
        	            	pods "ip-10-0-134-12us-west-1computeinternal-debug" is forbidden: violates PodSecurity "restricted:latest": host namespaces (hostNetwork=true, hostPID=true, hostIPC=true), privileged (container "container-00" must not set securityContext.privileged=true), allowPrivilegeEscalation != false (container "container-00" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "container-00" must set securityContext.capabilities.drop=["ALL"]), restricted volume types (volume "host" uses restricted volume type "hostPath"), runAsNonRoot != true (pod or container "container-00" must set securityContext.runAsNonRoot=true), runAsUser=0 (container "container-00" must not set runAsUser=0), seccompProfile (pod or container "container-00" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

OCPBUGS-19052: Avoid caching etcdctl on cluster-backup.sh

Elbehery · 2023-09-21T11:25:11Z

test/e2e/backup_script_test.go

@@ -19,7 +19,7 @@ import (
 const (
 	masterNodeLabel = "node-role.kubernetes.io/master"
 	backupPath      = "/etc/kubernetes/backup-happy-path-2023-08-03_152313"
-	debugNamespace  = "default"
+	debugNamespace  = "openshift-etcd" // using a privileged ns to pass on fips


lgtm 👍🏽

tjungblu · 2023-10-04T11:19:56Z

/jira refresh

openshift-ci-robot · 2023-10-04T11:20:03Z

@tjungblu: This pull request references Jira Issue OCPBUGS-19378, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.z) matches configured target version for branch (4.13.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-19454 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-19454 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

Requesting review from QA contact:
/cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tjungblu · 2023-10-04T11:20:04Z

/hold cancel

openshift-ci-robot · 2023-10-04T11:20:05Z

@tjungblu: This pull request references Jira Issue OCPBUGS-19378, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.z) matches configured target version for branch (4.13.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-19454 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-19454 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

Requesting review from QA contact:
/cc @geliu2016

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tjungblu · 2023-10-04T11:20:56Z

/cherry-pick release-4.12

openshift-cherrypick-robot · 2023-10-04T11:20:58Z

@tjungblu: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tjungblu · 2023-10-04T11:22:03Z

/label backport-risk-assessed

openshift-ci · 2023-10-04T11:22:06Z

@tjungblu: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sandeepknd · 2023-10-04T11:56:47Z

/label cherry-pick-approved

sandeepknd · 2023-10-04T12:01:49Z

/retest

dusk125 · 2023-10-04T13:17:24Z

/label backport-risk-assessed

tjungblu · 2023-10-04T14:19:32Z

/lgtm

(Mustafa already reviewed earlier)

openshift-ci · 2023-10-04T14:19:42Z

@tjungblu: you cannot LGTM your own PR.

In response to this:

/lgtm

(Mustafa already reviewed earlier)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dusk125 · 2023-10-04T14:29:46Z

/lgtm

openshift-ci · 2023-10-04T14:35:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Elbehery,dusk125,tjungblu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-10-04T15:37:19Z

/retest-required

Remaining retests: 0 against base HEAD ce4cf20 and 2 for PR HEAD 523ea2d in total

openshift-ci · 2023-10-04T17:26:49Z

@tjungblu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-10-04T17:32:16Z

@tjungblu: Jira Issue OCPBUGS-19378: Some pull requests linked via external trackers have merged:

openshift/cluster-etcd-operator#1117

The following pull requests linked via external trackers have not merged:

openshift/origin#28267 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-19378 has not been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-10-04T17:33:08Z

@tjungblu: new pull request created: #1130

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot and others added 5 commits September 20, 2023 13:17

add env flags for different restore scenarios

02c919f

add rev bumps and etcdutl

5d5e10b

OCPBUGS-18357: prepend authfile to podman create

2593bba

restore the correct static pod list

ab20549

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 20, 2023

openshift-ci bot requested review from dusk125 and Elbehery September 20, 2023 11:28

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023

tjungblu mentioned this pull request Sep 20, 2023

[release-4.13] OCPBUGS-18840: prepend authfile to podman create #1107

Closed

openshift-ci bot assigned Elbehery Sep 20, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023

carry helpers for backup e2e test

69aa51f

tjungblu force-pushed the OCPBUGS-19378_backport_413 branch from 1d1fb26 to 69aa51f Compare September 20, 2023 11:44

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023

openshift-merge-robot and others added 2 commits September 21, 2023 10:15

Merge pull request openshift#1113 from tjungblu/cached_etcdctl

8384cfe

OCPBUGS-19052: Avoid caching etcdctl on cluster-backup.sh

switch debug pod namespace in backup test

523ea2d

Elbehery reviewed Sep 21, 2023

View reviewed changes

tjungblu changed the title ~~OCPBUGS-19378: Backports of backup/restore fixes~~ OCPBUGS-19378: [4.13] Backports of backup/restore fixes Oct 4, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 4, 2023

openshift-ci bot requested a review from geliu2016 October 4, 2023 11:20

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 4, 2023

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 4, 2023

openshift-ci bot assigned dusk125 Oct 4, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023

openshift-ci bot merged commit ebb7c5d into openshift:release-4.13 Oct 4, 2023
12 checks passed

openshift-cherrypick-robot mentioned this pull request Oct 4, 2023

OCPBUGS-20100: [4.12] Backports of backup/restore fixes #1130

Closed

openshift-ci-robot mentioned this pull request Oct 19, 2023

OCPBUGS-19378: [4.13] backport etcd restore tests openshift/origin#28267

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-19378: [4.13] Backports of backup/restore fixes #1117

OCPBUGS-19378: [4.13] Backports of backup/restore fixes #1117

tjungblu commented Sep 20, 2023

openshift-ci-robot commented Sep 20, 2023

Elbehery commented Sep 20, 2023

tjungblu commented Sep 20, 2023

tjungblu commented Sep 20, 2023

Elbehery Sep 21, 2023

tjungblu commented Oct 4, 2023

openshift-ci-robot commented Oct 4, 2023

tjungblu commented Oct 4, 2023

openshift-ci-robot commented Oct 4, 2023

tjungblu commented Oct 4, 2023

openshift-cherrypick-robot commented Oct 4, 2023

tjungblu commented Oct 4, 2023

openshift-ci bot commented Oct 4, 2023

sandeepknd commented Oct 4, 2023

sandeepknd commented Oct 4, 2023

dusk125 commented Oct 4, 2023

tjungblu commented Oct 4, 2023

openshift-ci bot commented Oct 4, 2023

dusk125 commented Oct 4, 2023

openshift-ci bot commented Oct 4, 2023

openshift-ci-robot commented Oct 4, 2023

openshift-ci bot commented Oct 4, 2023

openshift-ci-robot commented Oct 4, 2023

openshift-cherrypick-robot commented Oct 4, 2023

OCPBUGS-19378: [4.13] Backports of backup/restore fixes #1117

OCPBUGS-19378: [4.13] Backports of backup/restore fixes #1117

Conversation

tjungblu commented Sep 20, 2023

openshift-ci-robot commented Sep 20, 2023

Elbehery commented Sep 20, 2023

tjungblu commented Sep 20, 2023

tjungblu commented Sep 20, 2023

Elbehery Sep 21, 2023

Choose a reason for hiding this comment

tjungblu commented Oct 4, 2023

openshift-ci-robot commented Oct 4, 2023

tjungblu commented Oct 4, 2023

openshift-ci-robot commented Oct 4, 2023

tjungblu commented Oct 4, 2023

openshift-cherrypick-robot commented Oct 4, 2023

tjungblu commented Oct 4, 2023

openshift-ci bot commented Oct 4, 2023

sandeepknd commented Oct 4, 2023

sandeepknd commented Oct 4, 2023

dusk125 commented Oct 4, 2023

tjungblu commented Oct 4, 2023

openshift-ci bot commented Oct 4, 2023

dusk125 commented Oct 4, 2023

openshift-ci bot commented Oct 4, 2023

openshift-ci-robot commented Oct 4, 2023

openshift-ci bot commented Oct 4, 2023

openshift-ci-robot commented Oct 4, 2023

openshift-cherrypick-robot commented Oct 4, 2023