Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-19837: Update staticpod file permissions to conform with CIS benchmarks #1128

Merged
merged 2 commits into from Oct 3, 2023
Merged

[release-4.12] OCPBUGS-19837: Update staticpod file permissions to conform with CIS benchmarks #1128

merged 2 commits into from Oct 3, 2023

Conversation

ardaguclu
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2023
@openshift-ci-robot
Copy link

@ardaguclu: This pull request references Jira Issue OCPBUGS-19837, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-19825 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-19825 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @kasturinarra

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR is a manual cherry-pick of these 3 PRs;

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 2, 2023
@Elbehery
Copy link
Contributor

Elbehery commented Oct 2, 2023

/lgtm
/approve

@ardaguclu
Copy link
Member Author

/hold
there seems to be a discrepancy

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 2, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2023
@ardaguclu
Copy link
Member Author

For the maintainers of this repository;

4.12 version of this repo was bumped to 4.13 version of library-go(which shouldn't be I suppose) and when I bump library-go 4.12, build fails. Thus, I had to update to the library-go 4.13's latest version. I hope it will be ok.

@Elbehery
Copy link
Contributor

Elbehery commented Oct 2, 2023

/retest-required

@ardaguclu
Copy link
Member Author

/retest

2 similar comments
@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

I think, required etcd-scaling test is permafailing.

/retest
/cc @dusk125
could you PTAL this(this one is the last one)? - please note this #1128 (comment)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2023

@ardaguclu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-disruptive-ovn 9af5922 link false /test e2e-gcp-disruptive-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sandeepknd
Copy link

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

@sandeepknd: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 3, 2023
Merged
@Elbehery
Copy link
Contributor

Elbehery commented Oct 3, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, Elbehery

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ardaguclu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2023
@dusk125
Copy link
Contributor

dusk125 commented Oct 3, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 3, 2023
@sandeepknd
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 3, 2023
@openshift-ci openshift-ci bot merged commit e49f1a3 into openshift:release-4.12 Oct 3, 2023
11 of 12 checks passed
@openshift-ci-robot
Copy link

@ardaguclu: Jira Issue OCPBUGS-19837: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19837 has been moved to the MODIFIED state.

In response to this:

This PR is a manual cherry-pick of these 3 PRs;

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu ardaguclu deleted the ocpbugs-19837 branch October 3, 2023 17:38
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-10-03-162701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasturinarra kasturinarra Awaiting requested review from kasturinarra

@dusk125 dusk125 Awaiting requested review from dusk125

@Elbehery Elbehery Awaiting requested review from Elbehery

Assignees

@Elbehery Elbehery

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ardaguclu @openshift-ci-robot @Elbehery @sandeepknd @dusk125 @openshift-merge-robot