Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-19987: relax readiness to local serializable requests #1134

Merged
merged 1 commit into from Oct 9, 2023
Merged

OCPBUGS-19987: relax readiness to local serializable requests #1134

merged 1 commit into from Oct 9, 2023

Conversation

tjungblu
Copy link
Contributor

@tjungblu tjungblu commented Oct 6, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 6, 2023
@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-19987, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor Author

tjungblu commented Oct 6, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

@tjungblu: The following commands are available to trigger required jobs:

  • /test configmap-scale
  • /test e2e-agnostic-ovn
  • /test e2e-agnostic-ovn-upgrade
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-single-node
  • /test e2e-operator
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-disruptive-ovn
  • /test e2e-aws-etcd-recovery
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-gcp
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-disruptive-ovn
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-qe-no-capabilities
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-serial-ipv4
  • /test e2e-metal-single-node-live-iso
  • /test e2e-operator-fips
  • /test e2e-vsphere-ovn-etcd-scaling

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-etcd-operator-master-e2e-agnostic-ovn
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-agnostic-ovn-upgrade
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-etcd-recovery
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-etcd-scaling
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp-qe-no-capabilities
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-operator
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-operator-fips
  • pull-ci-openshift-cluster-etcd-operator-master-images
  • pull-ci-openshift-cluster-etcd-operator-master-unit
  • pull-ci-openshift-cluster-etcd-operator-master-verify
  • pull-ci-openshift-cluster-etcd-operator-master-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor Author

tjungblu commented Oct 6, 2023

/payload 4.15 nightly blocking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

@tjungblu: trigger 8 job(s) of type blocking for the nightly release of OCP 4.15

  • periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.15-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.15-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-sdn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/89c5fc60-6427-11ee-9f11-49aa2c87233c-0

@tjungblu
Copy link
Contributor Author

tjungblu commented Oct 6, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@tjungblu: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 6, 2023
@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-19987, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-19987, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Elbehery
Copy link
Contributor

Elbehery commented Oct 9, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit b52b83f into openshift:master Oct 9, 2023
12 of 14 checks passed
@openshift-ci-robot
Copy link

@tjungblu: Jira Issue OCPBUGS-19987: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19987 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@tjungblu: new pull request created: #1135

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 9, 2023
Merged
@benluddy benluddy mentioned this pull request Nov 1, 2023
Closed
benluddy
benluddy reviewed Nov 1, 2023
View reviewed changes
pkg/cmd/readyz/readyz.go
http.Error(w, fmt.Sprintf("failed to get member endpoint status: %v", err), http.StatusServiceUnavailable)
return
}
timeout, cancel := context.WithTimeout(ctx, 60*time.Second)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this context be derived from the context of the *http.Request (r.Context()) passed to each handler invocation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluddy benluddy benluddy left review comments

@Elbehery Elbehery Awaiting requested review from Elbehery

@hasbro17 hasbro17 Awaiting requested review from hasbro17

Assignees

@Elbehery Elbehery

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tjungblu @openshift-ci-robot @openshift-cherrypick-robot @Elbehery @benluddy