Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ownership for etcd-ca-bundle that I don't think is updated #1159

Merged
merged 1 commit into from Jan 5, 2024

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Nov 17, 2023

This is input from the installer, but its not user provided so it is logically owned by the component

This is input from the installer, but its not user provided
so it is logically owned by the component
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2023
@vrutkovs
Copy link
Member

/retest-required

2 similar comments
@tjungblu
Copy link
Contributor

/retest-required

@Elbehery
Copy link
Contributor

/retest-required

@hasbro17
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hasbro17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5d5f8b1 and 2 for PR HEAD 6f5cf37 in total

@deads2k
Copy link
Contributor Author

deads2k commented Nov 29, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 99be19d and 1 for PR HEAD 6f5cf37 in total

@deads2k
Copy link
Contributor Author

deads2k commented Nov 30, 2023

/override ci/prow/e2e-gcp-qe-no-capabilities

@deads2k
Copy link
Contributor Author

deads2k commented Nov 30, 2023

/retest-required

Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-gcp-qe-no-capabilities

In response to this:

/override ci/prow/e2e-gcp-qe-no-capabilities

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor Author

deads2k commented Dec 5, 2023

/retest-required

@deads2k
Copy link
Contributor Author

deads2k commented Dec 11, 2023

/test all

@dusk125
Copy link
Contributor

dusk125 commented Jan 3, 2024

/retest

@hasbro17
Copy link
Contributor

hasbro17 commented Jan 3, 2024

Looks like we recently marked the optional job ci/prow/e2e-gcp-qe-no-capabilities as required when this has always been broken (never gets past install).
https://github.com/openshift/release/pull/46081/files#diff-5df78ebd940cf6ec32ec37afdacd3b9bbd95ca2f94fc3ff343ea1ad77eff9d9fL234

https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp-qe-no-capabilities?

Going to override for now and mark that optional again until we can revisit if we need that job to run here.

@hasbro17
Copy link
Contributor

hasbro17 commented Jan 3, 2024

/override ci/prow/e2e-gcp-qe-no-capabilities

Copy link
Contributor

openshift-ci bot commented Jan 3, 2024

@hasbro17: Overrode contexts on behalf of hasbro17: ci/prow/e2e-gcp-qe-no-capabilities

In response to this:

/override ci/prow/e2e-gcp-qe-no-capabilities

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hasbro17
Copy link
Contributor

hasbro17 commented Jan 3, 2024

/retest-required

1 similar comment
@Elbehery
Copy link
Contributor

Elbehery commented Jan 4, 2024

/retest-required

@Elbehery
Copy link
Contributor

Elbehery commented Jan 4, 2024

Looks like we recently marked the optional job ci/prow/e2e-gcp-qe-no-capabilities as required when this has always been broken (never gets past install). https://github.com/openshift/release/pull/46081/files#diff-5df78ebd940cf6ec32ec37afdacd3b9bbd95ca2f94fc3ff343ea1ad77eff9d9fL234

https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp-qe-no-capabilities?

Going to override for now and mark that optional again until we can revisit if we need that job to run here.

raised openshift/release#47252

Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

@deads2k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery 6f5cf37 link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hasbro17
Copy link
Contributor

hasbro17 commented Jan 5, 2024

The SNO test seems quite flaky as it's giving different failures on each run.
For the latest one, this test failing does not seem related to the annotation change on the etcd ca configmap here.
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-etcd-operator/1159/pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-single-node/1742873399476097024

[FAIL] [sig-node] [Conformance] Prevent openshift node labeling on update by the node [It] TestOpenshiftNodeLabeling [Suite:openshift/conformance/parallel/minimal]
    github.com/openshift/origin/test/extended/security/labels.go:39

https://github.com/openshift/origin/blob/b4b9ccc5569f5669e3d901a7c4da93d62d0f3a49/test/extended/security/labels.go#L26-L41

I'm opting to override for now since this is mostly a metadata change and not related to the test failure.

/override ci/prow/e2e-aws-ovn-single-node

Copy link
Contributor

openshift-ci bot commented Jan 5, 2024

@hasbro17: Overrode contexts on behalf of hasbro17: ci/prow/e2e-aws-ovn-single-node

In response to this:

The SNO test seems quite flaky as it's giving different failures on each run.
For the latest one, this test failing does not seem related to the annotation change on the etcd ca configmap here.
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-etcd-operator/1159/pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-single-node/1742873399476097024

[FAIL] [sig-node] [Conformance] Prevent openshift node labeling on update by the node [It] TestOpenshiftNodeLabeling [Suite:openshift/conformance/parallel/minimal]
   github.com/openshift/origin/test/extended/security/labels.go:39

https://github.com/openshift/origin/blob/b4b9ccc5569f5669e3d901a7c4da93d62d0f3a49/test/extended/security/labels.go#L26-L41

I'm opting to override for now since this is mostly a metadata change and not related to the test failure.

/override ci/prow/e2e-aws-ovn-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9e38f4d into openshift:master Jan 5, 2024
13 of 14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.16.0-202401050151.p0.g9e38f4d.assembly.stream for distgit cluster-etcd-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants