Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: bump library-go and use default UnhealthyPodEvictionPolicy #1171

Merged

Conversation

atiratree
Copy link
Member

etcd should use a default UnhealthyPodEvictionPolicy behavior corresponding to the
IfHealthyBudget policy. This policy achieves the least amount of disruption, as it
does not allow eviction when multiple etcd pods do not report readiness.
This can block node drain/maintenance. The cluster administrator should then
analyze these pods and decide which one to bring down manually.

As opposed to for example to kube-apiserver that can use more permissive eviction policy: openshift/cluster-kube-apiserver-operator#1579

etcd should use a default UnhealthyPodEvictionPolicy behavior corresponding to the
IfHealthyBudget policy. This policy achieves the least amount of disruption, as it
does not allow eviction when multiple etcd pods do not report readiness.
This can block node drain/maintenance. The cluster administrator should then
 analyze these pods and decide which one to bring down manually.
@atiratree
Copy link
Member Author

/retest

4 similar comments
@atiratree
Copy link
Member Author

/retest

@atiratree
Copy link
Member Author

/retest

@atiratree
Copy link
Member Author

/retest

@Elbehery
Copy link
Contributor

/retest

@Elbehery
Copy link
Contributor

cc @hasbro17 @dusk125

@ingvagabund
Copy link
Member

/retest-required

@dusk125
Copy link
Contributor

dusk125 commented Jan 9, 2024

/retest-required
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, dusk125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@dusk125
Copy link
Contributor

dusk125 commented Jan 9, 2024

This test is being made optional openshift/release#47252
/override ci/prow/e2e-gcp-qe-no-capabilities

Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

@dusk125: Overrode contexts on behalf of dusk125: ci/prow/e2e-gcp-qe-no-capabilities

In response to this:

This test is being made optional openshift/release#47252
/override ci/prow/e2e-gcp-qe-no-capabilities

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Member

/retitle NO-JIRA: bump library-go and use default UnhealthyPodEvictionPolicy

This PR bumps library-go only. The change under pkg/operator/starter.go reflects the new API which is no-op for this operator.

@openshift-ci openshift-ci bot changed the title bump library-go and use default UnhealthyPodEvictionPolicy NO-JIRA: bump library-go and use default UnhealthyPodEvictionPolicy Jan 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 9, 2024
@openshift-ci-robot
Copy link

@atiratree: This pull request explicitly references no jira issue.

In response to this:

etcd should use a default UnhealthyPodEvictionPolicy behavior corresponding to the
IfHealthyBudget policy. This policy achieves the least amount of disruption, as it
does not allow eviction when multiple etcd pods do not report readiness.
This can block node drain/maintenance. The cluster administrator should then
analyze these pods and decide which one to bring down manually.

As opposed to for example to kube-apiserver that can use more permissive eviction policy: openshift/cluster-kube-apiserver-operator#1579

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9e38f4d and 2 for PR HEAD 647af2f in total

Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

@atiratree: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery 647af2f link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Member

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit a13dff1 into openshift:master Jan 9, 2024
13 of 14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.16.0-202401100232.p0.ga13dff1.assembly.stream for distgit cluster-etcd-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants