Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: remove cluster-backup pod #1182

Merged

Conversation

lance5890
Copy link
Contributor

As the UpgradeBackupController has been removed by the PR #1129

the cluster-backup-pod has no effect anymore

Signed-off-by: lan.tian <lance5890@163.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 16, 2024
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2024
@lance5890
Copy link
Contributor Author

/retest

2 similar comments
@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

/retest-required

@lance5890
Copy link
Contributor Author

/retest

7 similar comments
@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

lance5890 commented Jan 21, 2024

prow/e2e-gcp-qe-no-capabilities is being made optional

openshift/release#47252
openshift/release#47890

@lance5890
Copy link
Contributor Author

/retest-required

@tjungblu
Copy link
Contributor

Thanks @lance5890! We have to wait until the nightly builds are catching up and the label requirements are lifted, but otherwise

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance5890, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 30, 2024
@lance5890
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 30, 2024
@tjungblu
Copy link
Contributor

/retitle NO-JIRA: remove cluster-backup pod

@openshift-ci openshift-ci bot changed the title remove cluster-backup-pod NO-JIRA: remove cluster-backup pod Apr 30, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 30, 2024
@openshift-ci-robot
Copy link

@lance5890: This pull request explicitly references no jira issue.

In response to this:

As the UpgradeBackupController has been removed by the PR #1129

the cluster-backup-pod has no effect anymore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tjungblu
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@tjungblu: This pull request explicitly references no jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tjungblu
Copy link
Contributor

@lance5890 it will likely retest for a while, I'll keep an eye out to get this merged soonish

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9351543 and 2 for PR HEAD 8ed112c in total

@tjungblu
Copy link
Contributor

/override ci/prow/e2e-operator-fips

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-operator-fips

In response to this:

/override ci/prow/e2e-operator-fips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor

/override ci/prow/e2e-agnostic-ovn-upgrade
/override ci/prow/e2e-gcp-qe-no-capabilities
/override ci/prow/e2e-aws-ovn-single-node

unrelated failures

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-agnostic-ovn-upgrade, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-gcp-qe-no-capabilities

In response to this:

/override ci/prow/e2e-agnostic-ovn-upgrade
/override ci/prow/e2e-gcp-qe-no-capabilities
/override ci/prow/e2e-aws-ovn-single-node

unrelated failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@lance5890: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tjungblu
Copy link
Contributor

Thanks @lance5890 and sorry for the long wait

@openshift-merge-bot openshift-merge-bot bot merged commit cb78ee2 into openshift:master Apr 30, 2024
14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202404302014.p0.gcb78ee2.assembly.stream.el9 for distgit cluster-etcd-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants