OCPBUGS-30245: [4.13] Replace nodelister with master nodelister everywhere

[tjungblu]

From profiling on cert rotation we know that the node informer is called every couple of seconds on node heartbeats. This PR will ensure that all our node listers only ever listen/inform on the master node updates to reduce the frequency of unnecessary sync calls.

[openshift-ci-robot]

@tjungblu: This pull request references Jira Issue OCPBUGS-30245, which is invalid:

• expected the bug to target either version "4.13." or "openshift-4.13.", but it targets "4.14.z" instead
• expected dependent Jira Issue OCPBUGS-30012 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

From profiling on cert rotation we know that the node informer is called every couple of seconds on node heartbeats. This PR will ensure that all our node listers only ever listen/inform on the master node updates to reduce the frequency of unnecessary sync calls.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Elbehery]

/lgtm
/approve
/retest-required

[tjungblu]

/retest-required

[tjungblu]

/retest-required

[Elbehery]

/retest-required

[tjungblu]

/jira refresh

[openshift-ci-robot]

@tjungblu: This pull request references Jira Issue OCPBUGS-30245, which is invalid:

• expected the bug to target either version "4.13." or "openshift-4.13.", but it targets "4.14.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tjungblu]

/jira refresh

[openshift-ci-robot]

@tjungblu: This pull request references Jira Issue OCPBUGS-30245, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.z) matches configured target version for branch (4.13.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-30012 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-30012 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
• bug has dependents

Requesting review from QA contact:
/cc @geliu2016

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-disruptive	7882ceb	link	false	/test e2e-aws-disruptive
ci/prow/e2e-vsphere-ovn-etcd-scaling	7882ceb	link	false	/test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-disruptive	7882ceb	link	false	/test e2e-gcp-disruptive
ci/prow/e2e-aws-disruptive-ovn	7882ceb	link	false	/test e2e-aws-disruptive-ovn
ci/prow/e2e-metal-ipi-serial-ipv4	7882ceb	link	false	/test e2e-metal-ipi-serial-ipv4
ci/prow/e2e-gcp-ovn-etcd-scaling	7882ceb	link	false	/test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-disruptive-ovn	7882ceb	link	false	/test e2e-gcp-disruptive-ovn
ci/prow/e2e-gcp-qe-no-capabilities	7882ceb	link	false	/test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[geliu2016]

/label cherry-pick-approved

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, geliu2016, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Elbehery,tjungblu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tjungblu]

@Elbehery can you add the BPA label here please?
#1216

[tjungblu]

/label backport-risk-assessed

[tjungblu]

/cherry-pick release-4.12

[openshift-cherrypick-robot]

@tjungblu: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@tjungblu: Jira Issue OCPBUGS-30245: All pull requests linked via external trackers have merged:

• openshift/cluster-etcd-operator#1216
• openshift/cluster-etcd-operator#1211

Jira Issue OCPBUGS-30245 has been moved to the MODIFIED state.

In response to this:

From profiling on cert rotation we know that the node informer is called every couple of seconds on node heartbeats. This PR will ensure that all our node listers only ever listen/inform on the master node updates to reduce the frequency of unnecessary sync calls.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@tjungblu: new pull request created: #1224

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.13.0-202403141739.p0.g44e591d.assembly.stream.el8 for distgit cluster-etcd-operator.
All builds following this will include this PR.