Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "OCPBUGS-30169: add timeout to etcd client.New config" #1222

Merged

Conversation

tjungblu
Copy link
Contributor

Reverts #1215

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 13, 2024
@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-30169, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #1215

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 13, 2024
@openshift-ci openshift-ci bot requested review from dusk125 and Elbehery March 13, 2024 12:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@Elbehery
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@tjungblu
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 13, 2024
@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-30169, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from geliu2016 March 13, 2024 12:57
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 463979a and 2 for PR HEAD 9ae382e in total

Copy link

@geliu2016 geliu2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 14, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 479c2c7 and 1 for PR HEAD 9ae382e in total

@tjungblu
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-operator-fips

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-operator-fips

In response to this:

/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-operator-fips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Elbehery
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, geliu2016, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tjungblu
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-operator-fips

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-operator-fips

In response to this:

/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-operator-fips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn-single-node

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-single-node

In response to this:

/override ci/prow/e2e-aws-ovn-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor Author

omfg 🤣 retesting again

@tjungblu
Copy link
Contributor Author

I'll override this clear waste of money of testing a revert the 200th time

/override ci/prow/e2e-agnostic-ovn
/override ci/prow/e2e-agnostic-ovn-upgrade
/override ci/prow/e2e-aws-ovn-etcd-scaling
/override ci/prow/e2e-operator

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-agnostic-ovn, ci/prow/e2e-agnostic-ovn-upgrade, ci/prow/e2e-aws-ovn-etcd-scaling, ci/prow/e2e-operator

In response to this:

I'll override this clear waste of money of testing a revert the 200th time

/override ci/prow/e2e-agnostic-ovn
/override ci/prow/e2e-agnostic-ovn-upgrade
/override ci/prow/e2e-aws-ovn-etcd-scaling
/override ci/prow/e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit a2747fc into openshift:master Mar 14, 2024
12 of 14 checks passed
@openshift-ci-robot
Copy link

@tjungblu: Jira Issue OCPBUGS-30169: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30169 has been moved to the MODIFIED state.

In response to this:

Reverts #1215

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-qe-no-capabilities 9ae382e link false /test e2e-gcp-qe-no-capabilities
ci/prow/e2e-aws-etcd-recovery 9ae382e link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.16.0-202403141746.p0.ga2747fc.assembly.stream.el9 for distgit cluster-etcd-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants