Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1802228: For etcd discovery domain, watch infrastructure not controller config #125

Conversation

retroflexer
Copy link
Contributor

Moving away from controller config.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2020
@retroflexer retroflexer force-pushed the watch-infrastructure-not-controllerconfig branch from 2ba0ac2 to 0dbd14a Compare February 12, 2020 05:03
@retroflexer retroflexer changed the title [WIP]: Watch infrastructure for etcd discovery domain, not controller config Watch infrastructure for etcd discovery domain, not controller config Feb 12, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2020
@retroflexer retroflexer force-pushed the watch-infrastructure-not-controllerconfig branch from 0dbd14a to 36b2c9a Compare February 12, 2020 05:22
@hexfusion
Copy link
Contributor

@retroflexer you need to fix verify

@retroflexer retroflexer force-pushed the watch-infrastructure-not-controllerconfig branch from 36b2c9a to 94911b4 Compare February 12, 2020 13:29
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2020
@retroflexer
Copy link
Contributor Author

@retroflexer you need to fix verify

Thanks. Pushed gofmt fixes.

@deads2k
Copy link
Contributor

deads2k commented Feb 12, 2020

are the dynamic clients still used? If not, please remove them.

@deads2k
Copy link
Contributor

deads2k commented Feb 12, 2020

/approve

but you need to fix dynamic client needs (I think it's cruft) before merge.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@retroflexer retroflexer force-pushed the watch-infrastructure-not-controllerconfig branch from 94911b4 to 3eb20d5 Compare February 12, 2020 15:59
@retroflexer
Copy link
Contributor Author

retroflexer commented Feb 12, 2020

but you need to fix dynamic client needs (I think it's cruft) before merge.

@deads2k Got rid of dynamicClients.

@retroflexer retroflexer changed the title Watch infrastructure for etcd discovery domain, not controller config Bug 1802228: For etcd discovery domain, watch infrastructure not controller config Feb 12, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 12, 2020
@openshift-ci-robot
Copy link

@retroflexer: This pull request references Bugzilla bug 1802228, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1802228: For etcd discovery domain, watch infrastructure not controller config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@retroflexer
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 12, 2020
@openshift-ci-robot
Copy link

@retroflexer: This pull request references Bugzilla bug 1802228, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 12, 2020
@deads2k
Copy link
Contributor

deads2k commented Feb 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4dc09fd into openshift:master Feb 12, 2020
@openshift-ci-robot
Copy link

@retroflexer: All pull requests linked via external trackers have merged. Bugzilla bug 1802228 has been moved to the MODIFIED state.

In response to this:

Bug 1802228: For etcd discovery domain, watch infrastructure not controller config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@retroflexer: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure 3eb20d5 link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@retroflexer retroflexer deleted the watch-infrastructure-not-controllerconfig branch February 12, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants