New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1802228: For etcd discovery domain, watch infrastructure not controller config #125
Bug 1802228: For etcd discovery domain, watch infrastructure not controller config #125
Conversation
2ba0ac2
to
0dbd14a
Compare
0dbd14a
to
36b2c9a
Compare
@retroflexer you need to fix verify |
36b2c9a
to
94911b4
Compare
Thanks. Pushed gofmt fixes. |
are the dynamic clients still used? If not, please remove them. |
/approve but you need to fix dynamic client needs (I think it's cruft) before merge. |
94911b4
to
3eb20d5
Compare
@deads2k Got rid of dynamicClients. |
@retroflexer: This pull request references Bugzilla bug 1802228, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@retroflexer: This pull request references Bugzilla bug 1802228, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, retroflexer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@retroflexer: All pull requests linked via external trackers have merged. Bugzilla bug 1802228 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@retroflexer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Moving away from controller config.