wait for cluster-bootstrap to finish before removing bootstrap etcd #144
Conversation
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
deads2k
force-pushed
the
wait-bootstrap
branch
from
e2c167f
to
e2977f5
Compare
|
/retest |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Gcp looks like infra flake /test e2e-gcp |
| c.eventRecorder.Event("BootstrapTeardownController", "safe to remove bootstrap") | ||
| // this is ugly until bootkube is updated, but we want to be sure that bootkube has time to be waiting to watch the condition coming back. | ||
| time.Sleep(10 * time.Second) | ||
| if err := c.etcdClient.MemberRemove("etcd-bootstrap"); err != nil { |
There was a problem hiding this comment.
q: if for some reason the bootstrap vm will be restaretd, will the bootstrap etd will rejoin the cluster automatically?
after openshift/cluster-bootstrap#31 merges, this will make the teardown more reliable.