Bug 1804751: remove guard budget controller

[alaypatel07]

This removes the guard budget controller and defers moving
the quorum guard to CEO namespace to the future.

[alaypatel07]

level=error
level=error msg="Error: Error applying IAM policy to project \"openshift-gce-devel-ci\": Too many conflicts.  Latest error: Error setting IAM policy for project \"openshift-gce-devel-ci\": googleapi: Error 409: There were concurrent policy changes. Please retry the whole read-modify-write with exponential backoff., aborted"
level=error
level=error msg="  on ../tmp/openshift-install-136644694/iam/main.tf line 11, in resource \"google_project_iam_member\" \"worker-storage-admin\":"
level=error msg="  11: resource \"google_project_iam_member\" \"worker-storage-admin\" {"
level=error
level=error

infra

/test e2e-gcp

[deads2k]

/retest

[hexfusion]

I am fine with this but understand by not replacing quorum-gaurd we still race to provide certs before we Alert. MCO is before CEO in CVO payload. With all we have done I am not why we don't just do this but we do have a lot of fish to fry.

LGTM

[hexfusion]

/lgtm

[openshift-ci-robot]

@alaypatel07: This pull request references Bugzilla bug 1804751, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1804751: remove guard budget controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@alaypatel07: This pull request references Bugzilla bug 1804751, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1804751: remove guard budget controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@alaypatel07: This pull request references Bugzilla bug 1804751, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1804751: remove guard budget controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@alaypatel07: This pull request references Bugzilla bug 1804751, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1804751: remove guard budget controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alaypatel07,hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alaypatel07,hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alaypatel07,hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hexfusion]

/bugzilla refresh

[openshift-ci-robot]

@hexfusion: This pull request references Bugzilla bug 1804751, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@alaypatel07: All pull requests linked via external trackers have merged. Bugzilla bug 1804751 has been moved to the MODIFIED state.

In response to this:

Bug 1804751: remove guard budget controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alaypatel07]

/cherrypick release-4.4

[openshift-cherrypick-robot]

@alaypatel07: #165 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/operator/guardbudget/guard_budget_controller.go
M	pkg/operator/starter.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/starter.go
CONFLICT (content): Merge conflict in pkg/operator/starter.go
CONFLICT (modify/delete): pkg/operator/guardbudget/guard_budget_controller.go deleted in remove guard_budget_congroller and modified in HEAD. Version HEAD of pkg/operator/guardbudget/guard_budget_controller.go left in tree.
Removing manifests/0000_12_etcd-operator_09_etcdquorumguard_deployment.yaml
Removing manifests/0000_12_etcd-operator_08_etcdquorumguard_pdb.yaml
Removing manifests/0000_12_etcd-operator_00_pdb-rolebinding.yaml
Patch failed at 0001 remove guard_budget_congroller

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[deads2k]

/cherrypick release-4.4

[openshift-cherrypick-robot]

@deads2k: #165 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/operator/starter.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/starter.go
CONFLICT (content): Merge conflict in pkg/operator/starter.go
Removing pkg/operator/guardbudget/guard_budget_controller.go
Removing manifests/0000_12_etcd-operator_09_etcdquorumguard_deployment.yaml
Removing manifests/0000_12_etcd-operator_08_etcdquorumguard_pdb.yaml
Removing manifests/0000_12_etcd-operator_00_pdb-rolebinding.yaml
Patch failed at 0001 remove guard_budget_congroller

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.