Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1806723: use correct IP for bootstrap host env vars #200

Merged
merged 2 commits into from
Feb 25, 2020
Merged

bug 1806723: use correct IP for bootstrap host env vars #200

merged 2 commits into from
Feb 25, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 24, 2020

before we were using the value that came from the installer, but @hexfusion's previous PR made that unreliable.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@deads2k deads2k changed the title use correct IP for bootstrap host env vars bug 1806723: use correct IP for bootstrap host env vars Feb 24, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 24, 2020
@openshift-ci-robot
Copy link

@deads2k: This pull request references Bugzilla bug 1806723, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bug 1806723: use correct IP for bootstrap host env vars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor

I am trying to get this working again.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

danwinship
danwinship reviewed Feb 24, 2020
View reviewed changes
pkg/operator/targetconfigcontroller/etcd_env.go
}
endpoints = append(endpoints, "https://"+urlHost+":2379")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could just do "https://"+net.JoinHostPort(bootstrapIP, "2379") and not need dnshelpers.GetURLHostForIP

@hexfusion hexfusion mentioned this pull request Feb 24, 2020
Closed
37 tasks
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Contributor

with this and openshift/installer#3176 I can now get to the point where cluster-etcd-operator fails because of Someone Else's Problem:

  - lastTransitionTime: "2020-02-25T02:11:29Z"
    message: 'NodeControllerDegraded: The master nodes not ready: node "dwinship-ipv6-2-cnkbh-master-0"
      not ready since 2020-02-25 02:14:52 +0000 UTC because KubeletNotReady (runtime
      network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network
      plugin returns error: Missing CNI default network), node "dwinship-ipv6-2-cnkbh-master-1"
      not ready since 2020-02-25 02:09:25 +0000 UTC because KubeletNotReady (runtime
      network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network
      plugin returns error: Missing CNI default network)'
    reason: NodeController_MasterNodesReady
    status: "True"
    type: Degraded

@openshift-merge-robot openshift-merge-robot merged commit e4e8d68 into openshift:master Feb 25, 2020
@openshift-ci-robot
Copy link

@deads2k: All pull requests linked via external trackers have merged. Bugzilla bug 1806723 has been moved to the MODIFIED state.

In response to this:

bug 1806723: use correct IP for bootstrap host env vars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@hexfusion hexfusion Awaiting requested review from hexfusion

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@hexfusion hexfusion

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@deads2k @openshift-ci-robot @hexfusion @openshift-bot @danwinship @openshift-merge-robot