Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1807054: fix recovery of master nodes restarting at the same time #203

Merged

Conversation

alaypatel07
Copy link
Contributor

@alaypatel07 alaypatel07 commented Feb 25, 2020

The ${ETCDCTL} member list will fail when all the masters
are restarted at the same time. It will be good to have the
member list, but if we don't, we should not fail and continue
to the discovery.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2020
@alaypatel07 alaypatel07 changed the title [WIP]: fix recovery of master node restarting at the same time [WIP]: fix recovery of master nodes restarting at the same time Feb 25, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@alaypatel07 alaypatel07 changed the title [WIP]: fix recovery of master nodes restarting at the same time [Bug 1807054]: fix recovery of master nodes restarting at the same time Feb 25, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2020
@alaypatel07
Copy link
Contributor Author

alaypatel07 commented Feb 25, 2020

FTR I was able to bring etcd pods back up in one of the failed cluster runs by manual edits included in this PR https://coreos.slack.com/archives/C027U68LP/p1582641688035800?thread_ts=1582598465.022300&cid=C027U68LP

@deads2k
Copy link
Contributor

deads2k commented Feb 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alaypatel07,deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bb86e74 into openshift:master Feb 26, 2020
@tnozicka tnozicka changed the title [Bug 1807054]: fix recovery of master nodes restarting at the same time Bug 1807054: fix recovery of master nodes restarting at the same time Feb 26, 2020
@openshift-ci-robot
Copy link

@alaypatel07: All pull requests linked via external trackers have merged. Bugzilla bug 1807054 has been moved to the MODIFIED state.

In response to this:

Bug 1807054: fix recovery of master nodes restarting at the same time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka
Copy link
Contributor

/cherrypick release-4.4

@openshift-cherrypick-robot

@tnozicka: new pull request created: #209

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion mentioned this pull request Feb 26, 2020
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants