Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1812584: fix scaling during upgrade and add unit tests #253

Merged
merged 3 commits into from Mar 12, 2020
Merged

Bug 1812584: fix scaling during upgrade and add unit tests #253

merged 3 commits into from Mar 12, 2020

Conversation

alaypatel07
Copy link
Contributor

@alaypatel07 alaypatel07 commented Mar 11, 2020 •
edited by hexfusion

4.4 bug 1813061

continued from #247

@alaypatel07
etcdcli: fix get member name for upgrades
a5a2477 
In 4.3 the etcd member name was populated as the hostname from discovery
init container.During upgrade cluster member controller should not add
a member with <node-name> if a member with <hostname> is running.
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 11, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@alaypatel07
Copy link
Contributor Author

/retest

@alaypatel07 alaypatel07 changed the title [WIP]: add unit tests for 4.3 -> 4.4 upgrade [WIP]: add unit tests for 4.3 -> 4.4 upgrade bug Mar 12, 2020
@alaypatel07 alaypatel07 changed the title [WIP]: add unit tests for 4.3 -> 4.4 upgrade bug add unit tests for 4.3 -> 4.4 upgrade bug Mar 12, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2020
@hexfusion hexfusion mentioned this pull request Mar 12, 2020
Closed
@hexfusion hexfusion changed the title add unit tests for 4.3 -> 4.4 upgrade bug Bug 1812584: add unit tests for 4.3 -> 4.4 upgrade bug Mar 12, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 12, 2020
@openshift-ci-robot
Copy link

@alaypatel07: This pull request references Bugzilla bug 1812584, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1812584: add unit tests for 4.3 -> 4.4 upgrade bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 12, 2020
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1812584, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 12, 2020
@hexfusion
Copy link
Contributor

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2020
@openshift-ci-robot
Copy link

@alaypatel07: This pull request references Bugzilla bug 1812584, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1812584: add unit tests for 4.3 -> 4.4 upgrade bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alaypatel07,hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@alaypatel07: This pull request references Bugzilla bug 1812584, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1812584: add unit tests for 4.3 -> 4.4 upgrade bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@alaypatel07: This pull request references Bugzilla bug 1812584, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1812584: add unit tests for 4.3 -> 4.4 upgrade bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit f148210 into openshift:master Mar 12, 2020
@openshift-ci-robot
Copy link

@alaypatel07: All pull requests linked via external trackers have merged. Bugzilla bug 1812584 has been moved to the MODIFIED state.

In response to this:

Bug 1812584: add unit tests for 4.3 -> 4.4 upgrade bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alaypatel07 alaypatel07 changed the title Bug 1812584: add unit tests for 4.3 -> 4.4 upgrade bug Bug 1812584: fix scaling during upgrade and add unit tests Mar 12, 2020
@hexfusion
Copy link
Contributor

/cherrypick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 13, 2020
Merged
@openshift-cherrypick-robot
Copy link

@hexfusion: new pull request created: #261

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexfusion hexfusion Awaiting requested review from hexfusion

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@hexfusion hexfusion

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alaypatel07 @openshift-ci-robot @hexfusion @openshift-cherrypick-robot @openshift-merge-robot