Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] [WIP]: pack node list in the revision for accurate env var #281

Closed
wants to merge 1 commit into from

Conversation

alaypatel07
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@alaypatel07
Copy link
Contributor Author

{
            "apiVersion": "v1",
            "data": {
                "nodes": "ip-10-0-136-109.ec2.internal, ip-10-0-129-124.ec2.internal, ip-10-0-157-225.ec2.internal"
            },
            "kind": "ConfigMap",
            "metadata": {
                "creationTimestamp": "2020-03-26T18:52:48Z",
                "name": "node-config",
                "namespace": "openshift-etcd",
                "resourceVersion": "4293",
                "selfLink": "/api/v1/namespaces/openshift-etcd/configmaps/node-config",
                "uid": "0b3e9692-4d6a-476e-9876-e87f7d3ad4a3"
            }
        },

@alaypatel07 alaypatel07 force-pushed the fix-dr branch 6 times, most recently from bc04563 to 74085bf Compare March 26, 2020 23:40
@openshift-ci-robot
Copy link

@alaypatel07: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-deps 1fd248c link /test verify-deps
ci/prow/e2e-aws-disruptive 1fd248c link /test e2e-aws-disruptive
ci/prow/e2e-gcp 1fd248c link /test e2e-gcp
ci/prow/e2e-aws 1fd248c link /test e2e-aws
ci/prow/e2e-azure 1fd248c link /test e2e-azure
ci/prow/e2e-gcp-upgrade 1fd248c link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alaypatel07
Copy link
Contributor Author

had a simpler solution with #284

/close

@openshift-ci-robot
Copy link

@alaypatel07: Closed this PR.

In response to this:

had a simpler solution with #284

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants